Error() methods now include offset and have more consistent messages#9
Open
rickb777 wants to merge 1 commit into
Open
Error() methods now include offset and have more consistent messages#9rickb777 wants to merge 1 commit into
rickb777 wants to merge 1 commit into
Conversation
… error spec testing reworked to compare the expected errors against the actual errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two changes in this PR.
Error messages
Error() methods now include offset information and have more consistent messages. Previously,
json5was hard to use because any error messages arising were not clear enough.Error spec testing
json5_test.goerror spec testing was enhanced so that the expected errors are compared against the actual errors. The expected messages have been updated to reflect current responses. Several newerrorSpecfiles have been added to align with current responses so that all test inputs containing invalid JSON5 now have a correspondingerrorSpecfile.What hasn't been done is to track the line and column information even though the existing
errorSpecfiles appear to anticipate this; maybe this should be done (as a separate PR).