Fix 6 failing CLI error handling tests

The tests expected ValueError to propagate from exec_command(), but
cliff framework catches exceptions and returns exit codes instead.

Updated tests to check:
- Return code equals 1 (error)
- Error message appears in stderr

Fixed tests:
- test_account_create_w_parameters_from_bad_file_format_fail
- test_group_create_w_parameters_from_bad_file_format_fail
- test_change_create_bad_file_format_fail
- test_project_create_w_parameters_from_bad_file_format_fail
- test_project_configuration_set_from_bad_file_format_fail
- test_plugin_install_w_wrong_identifier_fail

All 202 tests now pass.

Author: tivaliy

gerritclient/tests/unit/cli/test_account.py

@@ -115,17 +115,21 @@ def test_account_create_w_parameters_from_file(self):
         self.m_client.create.assert_called_once_with(username, data=test_data)
 
     @mock.patch("gerritclient.common.utils.file_exists", mock.Mock(return_value=True))
-    def test_account_create_w_parameters_from_bad_file_format_fail(self):
+    @mock.patch("sys.stderr")
+    def test_account_create_w_parameters_from_bad_file_format_fail(self, mocked_stderr):
         username = "fake-user"
         test_data = {}
         expected_path = "/tmp/fakes/bad_file.format"
         args = f"account create {username} --file {expected_path}"
 
         m_open = mock.mock_open(read_data=json.dumps(test_data))
         with mock.patch("gerritclient.common.utils.open", m_open, create=True):
-            self.assertRaisesRegex(
-                ValueError, "Unsupported data format", self.exec_command, args
+            result = self.exec_command(args)
+            self.assertEqual(1, result)
+            stderr_output = "".join(
+                call[0][0] for call in mocked_stderr.write.call_args_list
             )
+            self.assertIn("Unsupported data format", stderr_output)
 
     @mock.patch("sys.stderr")
     def test_account_create_fail(self, mocked_stderr):

gerritclient/tests/unit/cli/test_change.py

@@ -141,16 +141,20 @@ def test_change_create(self):
         self.m_client.create.assert_called_once_with(test_data)
 
     @mock.patch("gerritclient.common.utils.file_exists", mock.Mock(return_value=True))
-    def test_change_create_bad_file_format_fail(self):
+    @mock.patch("sys.stderr")
+    def test_change_create_bad_file_format_fail(self, mocked_stderr):
         test_data = {}
         expected_path = "/tmp/fakes/bad_file.format"
         args = f"change create {expected_path}"
 
         m_open = mock.mock_open(read_data=json.dumps(test_data))
         with mock.patch("gerritclient.common.utils.open", m_open, create=True):
-            self.assertRaisesRegex(
-                ValueError, "Unsupported data format", self.exec_command, args
+            result = self.exec_command(args)
+            self.assertEqual(1, result)
+            stderr_output = "".join(
+                call[0][0] for call in mocked_stderr.write.call_args_list
             )
+            self.assertIn("Unsupported data format", stderr_output)
 
     def test_change_delete(self):
         change_id = "I8473b95934b5732ac55d26311a706c9c2bde9940"

gerritclient/tests/unit/cli/test_group.py

@@ -84,17 +84,21 @@ def test_group_create_w_parameters_from_file(self):
         self.m_client.create.assert_called_once_with(group_name, data=test_data)
 
     @mock.patch("gerritclient.common.utils.file_exists", mock.Mock(return_value=True))
-    def test_group_create_w_parameters_from_bad_file_format_fail(self):
+    @mock.patch("sys.stderr")
+    def test_group_create_w_parameters_from_bad_file_format_fail(self, mocked_stderr):
         group_name = "Fake-Group"
         test_data = {}
         expected_path = "/tmp/fakes/bad_file.format"
         args = f"group create {group_name} --file {expected_path}"
 
         m_open = mock.mock_open(read_data=json.dumps(test_data))
         with mock.patch("gerritclient.common.utils.open", m_open, create=True):
-            self.assertRaisesRegex(
-                ValueError, "Unsupported data format", self.exec_command, args
+            result = self.exec_command(args)
+            self.assertEqual(1, result)
+            stderr_output = "".join(
+                call[0][0] for call in mocked_stderr.write.call_args_list
             )
+            self.assertIn("Unsupported data format", stderr_output)
 
     @mock.patch("sys.stderr")
     def test_group_project_fail(self, mocked_stderr):

gerritclient/tests/unit/cli/test_plugin.py

@@ -111,8 +111,9 @@ def test_plugin_install_w_wrong_identifier_fail(self, mocked_stderr):
         plugin_id = "bad-plugin-identifier"
         url = "http://url/path/to/plugin.jar"
         args = f"plugin install {plugin_id} --url {url}"
-        self.assertRaises(ValueError, self.exec_command, args)
-        self.assertIn(
-            'Plugin identifier must contain ".jar" prefix',
-            mocked_stderr.write.call_args_list[0][0][0],
+        result = self.exec_command(args)
+        self.assertEqual(1, result)
+        stderr_output = "".join(
+            call[0][0] for call in mocked_stderr.write.call_args_list
         )
+        self.assertIn('Plugin identifier must contain ".jar"', stderr_output)

gerritclient/tests/unit/cli/test_project.py

@@ -233,17 +233,21 @@ def test_project_create_w_parameters_from_file(self):
         self.m_client.create.assert_called_once_with(project_id, data=test_data)
 
     @mock.patch("gerritclient.common.utils.file_exists", mock.Mock(return_value=True))
-    def test_project_create_w_parameters_from_bad_file_format_fail(self):
+    @mock.patch("sys.stderr")
+    def test_project_create_w_parameters_from_bad_file_format_fail(self, mocked_stderr):
         project_id = "fakes/fake-project"
         test_data = {}
         expected_path = "/tmp/fakes/bad_file.format"
         args = f"project create {project_id} --file {expected_path}"
 
         m_open = mock.mock_open(read_data=json.dumps(test_data))
         with mock.patch("gerritclient.common.utils.open", m_open, create=True):
-            self.assertRaisesRegex(
-                ValueError, "Unsupported data format", self.exec_command, args
+            result = self.exec_command(args)
+            self.assertEqual(1, result)
+            stderr_output = "".join(
+                call[0][0] for call in mocked_stderr.write.call_args_list
             )
+            self.assertIn("Unsupported data format", stderr_output)
 
     @mock.patch("sys.stderr")
     def test_project_create_fail(self, mocked_stderr):
@@ -651,17 +655,21 @@ def test_project_configuration_set(self):
         self.m_client.set_config.assert_called_once_with(project_name, data=test_data)
 
     @mock.patch("gerritclient.common.utils.file_exists", mock.Mock(return_value=True))
-    def test_project_configuration_set_from_bad_file_format_fail(self):
+    @mock.patch("sys.stderr")
+    def test_project_configuration_set_from_bad_file_format_fail(self, mocked_stderr):
         project_name = "fakes/fake-project"
         test_data = {}
         expected_path = "/tmp/fakes/bad_file.format"
         args = f"project configuration set {project_name} --file {expected_path}"
 
         m_open = mock.mock_open(read_data=json.dumps(test_data))
         with mock.patch("gerritclient.common.utils.open", m_open, create=True):
-            self.assertRaisesRegex(
-                ValueError, "Unsupported data format", self.exec_command, args
+            result = self.exec_command(args)
+            self.assertEqual(1, result)
+            stderr_output = "".join(
+                call[0][0] for call in mocked_stderr.write.call_args_list
             )
+            self.assertIn("Unsupported data format", stderr_output)
 
     @mock.patch("sys.stderr")
     def test_project_configuration_set_fail(self, mocked_stderr):