Apply Ruff code quality improvements

- Fixed 103 style and code quality issues automatically
- Simplified boolean expressions (bool(...) instead of True if ... else False)
- Updated to modern super() syntax
- Removed explicit format string indices
- Fixed contextlib usage patterns

Ignored rules that would change behavior:
- B904: Exception chaining (maintains current error handling)
- N818: Exception naming (preserves established patterns)
- F401: Re-export imports in __init__.py

All 172 tests still passing.

Author: claude

docs/source/conf.py

@@ -15,20 +15,16 @@
 
 # Add any Sphinx extension module names here, as strings. They can be
 # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
-extensions = [
-    'sphinx.ext.autodoc',
-    'sphinx.ext.viewcode',
-    'cliff.sphinxext'
-]
+extensions = ["sphinx.ext.autodoc", "sphinx.ext.viewcode", "cliff.sphinxext"]
 
 # Options for cliff.sphinxext plugin
-autoprogram_cliff_application = 'gerrit'
+autoprogram_cliff_application = "gerrit"
 
 # The suffix of source filenames.
-source_suffix = '.rst'
+source_suffix = ".rst"
 
 # The master toctree document.
-master_doc = 'index'
+master_doc = "index"
 
 # General information about the project.
-project = 'python-gerritclient'
+project = "python-gerritclient"

gerritclient/client.py

@@ -63,7 +63,7 @@ def __init__(self, url, auth_type=None, username=None, password=None):
     def is_authed(self):
         """Checks whether credentials were passed."""
 
-        return True if self._auth else False
+        return bool(self._auth)
 
     @staticmethod
     def _make_common_headers():

gerritclient/commands/account.py

@@ -31,7 +31,7 @@ class AccountList(AccountMixIn, base.BaseListCommand):
     columns = ("_account_id",)
 
     def get_parser(self, app_name):
-        parser = super(AccountList, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument("query", help="Query string.")
         parser.add_argument(
             "--suggest", action="store_true", help="Get account suggestions."
@@ -86,7 +86,7 @@ class AccountShow(AccountMixIn, base.BaseShowCommand):
     columns = ("_account_id", "name", "email", "username", "status")
 
     def get_parser(self, prog_name):
-        parser = super(AccountShow, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "-a", "--all", action="store_true", help="Show more details about account."
         )
@@ -119,7 +119,7 @@ def attribute(self):
         pass
 
     def get_parser(self, prog_name):
-        parser = super(BaseAccountSetCommand, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )
@@ -132,9 +132,7 @@ def get_parser(self, prog_name):
 
     def take_action(self, parsed_args):
         self.action(parsed_args.account_id, parsed_args.attribute)
-        msg = (
-            f"{self.attribute.capitalize()} for the account with identifier '{parsed_args.account_id}' was successfully set.\n"
-        )
+        msg = f"{self.attribute.capitalize()} for the account with identifier '{parsed_args.account_id}' was successfully set.\n"
         self.app.stdout.write(msg)
 
 
@@ -207,7 +205,7 @@ class AccountSetPassword(AccountMixIn, base.BaseShowCommand):
     columns = ("account_identifier", "http_password")
 
     def get_parser(self, prog_name):
-        parser = super(AccountSetPassword, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         group = parser.add_mutually_exclusive_group(required=True)
         group.add_argument(
             "--generate", action="store_true", help="Generate HTTP password."
@@ -232,7 +230,7 @@ class AccountDeletePassword(AccountMixIn, base.BaseCommand):
     """Deletes the HTTP password of an account in Gerrit."""
 
     def get_parser(self, prog_name):
-        parser = super(AccountDeletePassword, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )
@@ -253,7 +251,7 @@ class AccountSSHKeyList(AccountMixIn, base.BaseListCommand):
     columns = ("seq", "ssh_public_key", "encoded_key", "algorithm", "comment", "valid")
 
     def get_parser(self, prog_name):
-        parser = super(AccountSSHKeyList, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )
@@ -272,7 +270,7 @@ class AccountSSHKeyShow(AccountMixIn, base.BaseShowCommand):
     columns = ("seq", "ssh_public_key", "encoded_key", "algorithm", "comment", "valid")
 
     def get_parser(self, app_name):
-        parser = super(AccountSSHKeyShow, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "-s",
             "--sequence-id",
@@ -298,13 +296,11 @@ class AccountSSHKeyAdd(AccountMixIn, base.BaseShowCommand):
     @staticmethod
     def get_file_path(file_path):
         if not utils.file_exists(file_path):
-            raise argparse.ArgumentTypeError(
-                f"File '{file_path}' does not exist"
-            )
+            raise argparse.ArgumentTypeError(f"File '{file_path}' does not exist")
         return file_path
 
     def get_parser(self, app_name):
-        parser = super(AccountSSHKeyAdd, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         group = parser.add_mutually_exclusive_group(required=True)
         group.add_argument("--ssh-key", help="The SSH public key.")
         group.add_argument(
@@ -334,7 +330,7 @@ class AccountSSHKeyDelete(AccountMixIn, base.BaseCommand):
     """Deletes an SSH key of a user in Gerrit."""
 
     def get_parser(self, prog_name):
-        parser = super(AccountSSHKeyDelete, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )
@@ -370,7 +366,7 @@ class AccountMembershipList(AccountMixIn, base.BaseListCommand):
     )
 
     def get_parser(self, prog_name):
-        parser = super(AccountMembershipList, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )
@@ -388,7 +384,7 @@ class AccountEmailAdd(AccountMixIn, base.BaseShowCommand):
     columns = ("email", "preferred", "pending_confirmation")
 
     def get_parser(self, app_name):
-        parser = super(AccountEmailAdd, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument("-e", "--email", required=True, help="Account email.")
         parser.add_argument(
             "--preferred", action="store_true", help="Set email address as preferred."
@@ -416,7 +412,7 @@ class AccountEmailDelete(AccountMixIn, base.BaseCommand):
     """Deletes an email address of an account in Gerrit."""
 
     def get_parser(self, prog_name):
-        parser = super(AccountEmailDelete, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "account_id", metavar="account-identifier", help="Account identifier."
         )

gerritclient/commands/base.py

@@ -29,7 +29,7 @@ class BaseCommand(command.Command, abc.ABC):
     """Base Gerrit Code Review Client command."""
 
     def __init__(self, *args, **kwargs):
-        super(BaseCommand, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)
         self.client = client.get_client(self.entity_name, VERSION)
 
     @property
@@ -98,7 +98,7 @@ def columns(self):
         pass
 
     def get_parser(self, app_name):
-        parser = super(BaseShowCommand, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
 
         parser.add_argument(
             "entity_id",
@@ -122,13 +122,11 @@ class BaseCreateCommand(BaseShowCommand, abc.ABC):
     @staticmethod
     def get_file_path(file_path):
         if not utils.file_exists(file_path):
-            raise argparse.ArgumentTypeError(
-                f"File '{file_path}' does not exist"
-            )
+            raise argparse.ArgumentTypeError(f"File '{file_path}' does not exist")
         return file_path
 
     def get_parser(self, prog_name):
-        parser = super(BaseCreateCommand, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "--file", type=self.get_file_path, help="File with metadata to be uploaded."
         )
@@ -164,7 +162,7 @@ def action_type(self):
         pass
 
     def get_parser(self, prog_name):
-        parser = super(BaseEntitySetState, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "entity_id",
             metavar=f"{self.entity_name}-identifier",
@@ -181,7 +179,7 @@ def take_action(self, parsed_args):
 
 class BaseDownloadCommand(BaseCommand, abc.ABC):
     def get_parser(self, prog_name):
-        parser = super(BaseDownloadCommand, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "-f",
             "--format",

gerritclient/commands/change.py

@@ -99,7 +99,7 @@ class ChangeList(ChangeMixIn, base.BaseListCommand):
     """Queries changes visible to the caller."""
 
     def get_parser(self, prog_name):
-        parser = super(ChangeList, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument("query", nargs="+", help="Query string.")
         parser.add_argument(
             "-l",
@@ -140,7 +140,7 @@ class ChangeShow(ChangeMixIn, base.BaseShowCommand):
     """Retrieves a change."""
 
     def get_parser(self, app_name):
-        parser = super(ChangeShow, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "-a",
             "--all",
@@ -190,13 +190,11 @@ class ChangeCreate(ChangeMixIn, base.BaseCommand, base.show.ShowOne):
     @staticmethod
     def get_file_path(file_path):
         if not utils.file_exists(file_path):
-            raise argparse.ArgumentTypeError(
-                f"File '{file_path}' does not exist"
-            )
+            raise argparse.ArgumentTypeError(f"File '{file_path}' does not exist")
         return file_path
 
     def get_parser(self, prog_name):
-        parser = super(ChangeCreate, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "file", type=self.get_file_path, help="File with metadata of a new change."
         )
@@ -257,7 +255,7 @@ class ChangeRevert(BaseChangeAction):
     parameters = ("message",)
 
     def get_parser(self, app_name):
-        parser = super(ChangeRevert, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "-m",
             "--message",
@@ -275,7 +273,7 @@ class ChangeMove(BaseChangeAction):
     parameters = ("branch", "message")
 
     def get_parser(self, app_name):
-        parser = super(ChangeMove, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument("-b", "--branch", required=True, help="Destination branch.")
         parser.add_argument(
             "-m", "--message", help="A message to be posted in this change's comments."
@@ -292,7 +290,7 @@ class ChangeSubmit(BaseChangeAction):
     parameters = ("on_behalf_of", "notify")
 
     def get_parser(self, app_name):
-        parser = super(ChangeSubmit, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "--on-behalf-of", help="Submit the change on behalf of the given user."
         )
@@ -315,7 +313,7 @@ class ChangeRebase(BaseChangeAction):
     parameters = ("parent",)
 
     def get_parser(self, app_name):
-        parser = super(ChangeRebase, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument("-p", "--parent", help="The new parent revision.")
         return parser
 
@@ -327,7 +325,7 @@ class ChangeDelete(ChangeMixIn, base.BaseCommand):
     """Deletes a change."""
 
     def get_parser(self, prog_name):
-        parser = super(ChangeDelete, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "change_id", metavar="change-identifier", help="Change identifier."
         )
@@ -357,7 +355,7 @@ class ChangeTopicSet(ChangeMixIn, base.BaseShowCommand):
     columns = ("topic",)
 
     def get_parser(self, app_name):
-        parser = super(ChangeTopicSet, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument("-t", "--topic", required=True, help="Topic of a change.")
         return parser
 
@@ -395,7 +393,7 @@ class ChangeAssigneeHistoryShow(ChangeMixIn, base.BaseListCommand):
     columns = ("_account_id", "name", "email", "username")
 
     def get_parser(self, prog_name):
-        parser = super(ChangeAssigneeHistoryShow, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "change_id", metavar="change-identifier", help="Change identifier."
         )
@@ -413,7 +411,7 @@ class ChangeAssigneeSet(ChangeMixIn, base.BaseShowCommand):
     columns = ("_account_id", "name", "email", "username")
 
     def get_parser(self, app_name):
-        parser = super(ChangeAssigneeSet, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "-a",
             "--account",
@@ -441,7 +439,7 @@ class ChangeDraftPublish(ChangeMixIn, base.BaseCommand):
     """Publishes a draft change."""
 
     def get_parser(self, prog_name):
-        parser = super(ChangeDraftPublish, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "change_id", metavar="change-identifier", help="Change identifier."
         )
@@ -467,7 +465,7 @@ class ChangeIndex(ChangeMixIn, base.BaseCommand):
     """Adds or updates the change in the secondary index."""
 
     def get_parser(self, prog_name):
-        parser = super(ChangeIndex, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "change_id", metavar="change-identifier", help="Change identifier."
         )
@@ -486,7 +484,7 @@ class ChangeCommentList(ChangeCommentMixIn, base.BaseListCommand):
     """Lists the published comments of all revisions of the change."""
 
     def get_parser(self, prog_name):
-        parser = super(ChangeCommentList, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             "change_id", metavar="change-identifier", help="Change identifier."
         )
@@ -531,7 +529,7 @@ class ChangeFix(ChangeMixIn, base.BaseShowCommand):
     """
 
     def get_parser(self, app_name):
-        parser = super(ChangeFix, self).get_parser(app_name)
+        parser = super().get_parser(app_name)
         parser.add_argument(
             "--delete-patchset",
             action="store_true",