chore: comment conventions, session rename, dead-code cleanup#170
Conversation
- Ban decorative `// ---` separators across src/ and tests/ (89 bare rulers removed, 159 labeled headers reduced to a plain //), and delete useless single-identifier labels that only restated the next declaration; enforce the rule via check_comment_style.py and document it in AGENTS.md. - Rename src/dmk.cpp -> src/session.cpp so the TU name matches its lifecycle content (Session, bootstrap, ModInfo). - Remove the unreachable 32-bit MinGW arm in memory_guarded.cpp; the single x86-64 gate already makes it dead code and the x64 VEH path is unchanged.
|
Important Review skippedToo many files! This PR contains 200 files, which is 50 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (200)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
// ---separators acrosssrc/andtests/. Bare rulers are dropped and labeled headers become a plain descriptive//; single-identifier labels that only restated the next declaration are removed. The rule is enforced bycheck_comment_style.pyand documented inAGENTS.md.src/dmk.cpptosrc/session.cppso the translation-unit name matches its lifecycle content (Session,bootstrap,ModInfo).memory_guarded.cpp; the single x86-64 gate already makes it dead code, and the x64 fault-guard path is unchanged.