Skip to content

Commit a3f212e

Browse files
committed
Cleanup
1 parent c27c0f1 commit a3f212e

18 files changed

Lines changed: 50 additions & 30 deletions

.eslintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# See https://github.com/eslint/eslint/issues/10341#issuecomment-440450160
1+
# https://github.com/eslint/eslint/issues/10341#issuecomment-440450160
22
!.*
33

44
.git/

.eslintrc.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// @ts-check
22

3-
module.exports = {
3+
/** @type {import('eslint').Linter.Config} */
4+
const config = {
45
parser: '@typescript-eslint/parser',
56
extends: [
67
// /!\ Order matters
@@ -39,7 +40,7 @@ module.exports = {
3940
'lines-between-class-members': 'off',
4041
'no-useless-constructor': 'off',
4142

42-
// See [no-return-assign should be configurable to ignore arrow-functions](https://github.com/eslint/eslint/issues/9471)
43+
// [no-return-assign should be configurable to ignore arrow-functions](https://github.com/eslint/eslint/issues/9471)
4344
'no-return-assign': 'off',
4445

4546
'import/no-extraneous-dependencies': 'off',
@@ -71,3 +72,5 @@ module.exports = {
7172
'react-hooks/exhaustive-deps': 'error'
7273
}
7374
};
75+
76+
module.exports = config;

.github/workflows/node.js.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
# https://github.com/actions/starter-workflows/blob/c934669ce246e6d64e54006b714b04199cbe445b/ci/node.js.yml
2+
13
name: Node.js CI
24

3-
on: [push]
5+
# https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#on
6+
on: [push, pull_request]
47

58
jobs:
69
build:

.github/workflows/npm-publish.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# https://github.com/actions/starter-workflows/blob/c934669ce246e6d64e54006b714b04199cbe445b/ci/npm-publish.yml
2+
13
name: Node.js Package
24

35
on:

.stylelintrc.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
// @ts-check
22

3-
module.exports = {
3+
/** @type {Partial<import('stylelint').Configuration>} */
4+
const config = {
45
extends: [
5-
// As of 2019/04/08, stylelint-config-airbnb is still at v0.0.0 and has not seen a release for a year
6-
// Should we keep this? Is this future proof?
6+
// As of 2020/03/18, stylelint-config-airbnb is still at v0.0.0
7+
// Is this future proof?
8+
// https://github.com/airbnb/css/pull/56
79
'stylelint-config-airbnb',
810

911
'stylelint-config-recommended-scss'
@@ -20,3 +22,5 @@ module.exports = {
2022
'order/order': null
2123
}
2224
};
25+
26+
module.exports = config;

examples/Bootstrap4.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ function Beatles() {
191191
);
192192
}
193193

194-
// See https://en.wikipedia.org/wiki/The_Velvet_Underground#Timeline
194+
// https://en.wikipedia.org/wiki/The_Velvet_Underground#Timeline
195195
const velvetUnderground: Person[] = [
196196
{
197197
id: '0',

examples/Boxes.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
.flex-fill {
55
//flex: 1 1 auto;
6-
// See [flex-grow vs flex](https://github.com/angular/material/issues/2632)
6+
// [flex-grow vs flex](https://github.com/angular/material/issues/2632)
77
flex: auto;
88
}
99

examples/jest-e2e.setup.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import 'regenerator-runtime/runtime';
77

88
import { toMatchImageSnapshot } from 'jest-image-snapshot';
99

10-
// See [Event: 'unhandledRejection'](https://nodejs.org/api/process.html#process_event_unhandledrejection)
11-
// See [Bluebird Error management configuration](http://bluebirdjs.com/docs/api/error-management-configuration.html)
10+
// [Event: 'unhandledRejection'](https://nodejs.org/api/process.html#process_event_unhandledrejection)
11+
// [Bluebird Error management configuration](http://bluebirdjs.com/docs/api/error-management-configuration.html)
1212
process.on('unhandledRejection', (reason: Error | any, _promise: Promise<any>) => {
1313
throw reason;
1414
});

examples/webpack.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const postcssPresetEnv = require('postcss-preset-env');
1212
* @param {any} _argv
1313
*/
1414
module.exports = (_webpackEnv, _argv) => {
15-
// See https://github.com/webpack/webpack/issues/6460#issuecomment-364286147
15+
// https://github.com/webpack/webpack/issues/6460#issuecomment-364286147
1616

1717
/** @type import('webpack').Configuration */
1818
const config = {
@@ -41,7 +41,7 @@ module.exports = (_webpackEnv, _argv) => {
4141
{
4242
test: /\.(js|tsx?)$/,
4343

44-
// See [Babel should not transpile core-js](https://github.com/zloirock/core-js/issues/514#issuecomment-476533317)
44+
// [Babel should not transpile core-js](https://github.com/zloirock/core-js/issues/514#issuecomment-476533317)
4545
exclude: /\/core-js/,
4646

4747
loader: 'babel-loader'

jest.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ const config = {
1818
coveragePathIgnorePatterns: [...defaults.coveragePathIgnorePatterns, './jest.setup.ts'],
1919

2020
// By default Jest allows for __tests__/*.js, *.spec.js and *.test.js
21-
// See https://jestjs.io/docs/en/configuration#testregex-string-array-string
22-
// let's be strict and use *.test.js only
21+
// https://jestjs.io/docs/en/configuration#testregex-string-array-string
22+
// Let's be strict and use *.test.js only
2323
testRegex: '\\.test\\.tsx?$'
2424
};
2525

0 commit comments

Comments
 (0)