Potential fix for code scanning alert no. 6: Arbitrary file access during archive extraction ("Zip Slip")#52
Merged
Conversation
…ss during archive extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: 梦里不知身是客 <liang.tang.cx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/tlcsdm/eclipse-rcp-example/security/code-scanning/6
To fix Zip Slip safely, normalize and validate each computed output path before any file operation. The best approach here is:
target.toAbsolutePath().normalize()).resolvedPath = targetPath.resolve(entry.getName()).normalize()if (!resolvedPath.startsWith(targetPath)) throw new IOException(...)resolvedPathfor directory creation and file copy.This single validation point addresses all three alert variants (directory creation, parent directory creation, and file copy).
Edits are only needed in
bundles/com.tlcsdm.eclipse.rcp.example.python3.win32.x86_64/src/com/tlcsdm/eclipse/rcp/example/python3/Activator.java, withininstall()around the ZIP extraction loop. No new dependency is required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.