Address most initial PR comments

Author: tleonhardt

.pre-commit-config.yaml

@@ -6,7 +6,6 @@ repos:
       - id: check-executables-have-shebangs
       - id: check-merge-conflict
       - id: check-toml
-      - id: check-yaml
       - id: detect-private-key
       - id: end-of-file-fixer
       - id: fix-byte-order-marker

pyproject.toml

@@ -45,14 +45,6 @@ dev = [
     "ruff>=0.14.10",
     "typos",
 ]
-quality = ["prek>=0.3.5"]
-test = [
-    "codecov>=2.1",
-    "coverage>=7.11",
-    "pytest>=8.1.1",
-    "pytest-cov>=5",
-    "pytest-mock>=3.14.1",
-]
 
 [project.urls]
 Homepage = "https://github.com/prompt-toolkit/python-prompt-toolkit"

src/prompt_toolkit/layout/containers.py

@@ -53,9 +53,7 @@
 from .utils import explode_text_fragments
 
 if TYPE_CHECKING:
-    from typing import TypeGuard
-
-    from typing_extensions import Protocol
+    from typing import Protocol, TypeGuard
 
     from prompt_toolkit.key_binding.key_bindings import NotImplementedOrNone
 

src/prompt_toolkit/layout/dimension.py

@@ -6,7 +6,7 @@
 from __future__ import annotations
 
 from collections.abc import Callable
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING
 
 __all__ = [
     "Dimension",
@@ -171,7 +171,7 @@ def max_layout_dimensions(dimensions: list[Dimension]) -> Dimension:
 
 
 # Anything that can be converted to a dimension
-AnyDimension = None | int | Dimension | Callable[[], Any]
+AnyDimension = None | int | Dimension | Callable[[], "AnyDimension"]
 
 
 def to_dimension(value: AnyDimension) -> Dimension:

tests/test_key_binding.py

@@ -43,6 +43,13 @@ def create_background_task(coroutine, **kw):
             coroutine.close()
             return None
 
+        # Don't start background tasks for these tests. The `KeyProcessor`
+        # wants to create a background task for flushing keys. We can ignore it
+        # here for these tests.
+        # This patch is not clean. In the future, when we can use Taskgroups,
+        # the `Application` should pass its task group to the constructor of
+        # `KeyProcessor`. That way, it doesn't have to do a lookup using
+        # `get_app()`.
         app.create_background_task = create_background_task
 
         with set_app(app):

tests/test_memory_leaks.py

@@ -14,6 +14,7 @@ def _count_prompt_session_instances() -> int:
     return len([obj for obj in objects if isinstance(obj, PromptSession)])
 
 
+# This test used to fail in GitHub CI, probably due to GC differences.
 def test_prompt_session_memory_leak() -> None:
     before_count = _count_prompt_session_instances()