fix: prevent unbounded memory growth in parse_powermetrics#93
Open
zubvit wants to merge 1 commit into
Open
Conversation
powermetrics appends a null-byte-separated plist entry to its output file on every interval tick and never truncates it. parse_powermetrics was reading the entire file on every loop iteration, so memory grew linearly with uptime (thousands of stale samples after an hour). Fix: seek to 64 KB before EOF and read only the tail. A single plist sample is 4-16 KB so data[-1] still gets the latest complete entry, but memory usage is now O(1) regardless of how long asitop runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
powermetricsappends a null-byte-separated plist entry to its output file on every interval tick and never truncates it.parse_powermetricscalledfp.read()on the entire file every loop iteration — after an hour at the default 1-second interval, it loads thousands of stale samples into RAM on every tick, with memory growing linearly with uptime.Fix
Seek to 64 KB before EOF and read only the tail. A single plist sample is 4–16 KB, so
data[-1]still gets the latest complete entry while memory usage becomes O(1) regardless of how long asitop runs.Tested on macOS with Apple M1, asitop 0.0.24.