fix(claude-code): handle missing trailing newline and fix directory ownership

Ensure rc files end with a newline before appending alias to prevent
concatenation onto the previous line. Chown fish config directories
individually so non-root users can manage their fish config.

Author: tmaier

src/claude-code/install.sh

@@ -70,6 +70,10 @@ if [ "${YOLOALIAS:-false}" = "true" ]; then
         fi
 
         touch "$rc_file"
+        # Ensure the file ends with a newline before appending
+        if [ -s "$rc_file" ] && [ "$(tail -c 1 "$rc_file" | wc -l)" -eq 0 ]; then
+            printf '\n' >> "$rc_file"
+        fi
         printf '%s\n' "$alias_cmd" >> "$rc_file"
     }
 
@@ -82,6 +86,7 @@ if [ "${YOLOALIAS:-false}" = "true" ]; then
     # fish — create a function file (idiomatic for fish)
     FISH_FUNC_DIR="$TARGET_HOME/.config/fish/functions"
     FISH_FUNC_FILE="$FISH_FUNC_DIR/yolo.fish"
+    FISH_CREATED=false
     if [ -f "$FISH_FUNC_FILE" ]; then
         echo "Skipping $FISH_FUNC_FILE: function already exists."
     else
@@ -91,12 +96,15 @@ function yolo --description "claude --allow-dangerously-skip-permissions"
     claude --allow-dangerously-skip-permissions $argv
 end
 FISHEOF
+        FISH_CREATED=true
     fi
 
     # Fix ownership if installing for non-root user
     if [ -n "$_REMOTE_USER" ] && [ "$_REMOTE_USER" != "root" ]; then
         chown "$_REMOTE_USER" "$TARGET_HOME/.bashrc" "$TARGET_HOME/.zshrc"
-        chown "$_REMOTE_USER" "$FISH_FUNC_FILE"
+        if [ "$FISH_CREATED" = true ]; then
+            chown "$_REMOTE_USER" "$TARGET_HOME/.config" "$TARGET_HOME/.config/fish" "$FISH_FUNC_DIR" "$FISH_FUNC_FILE"
+        fi
     fi
 
     echo "yolo alias configured for bash, zsh, and fish."

test/claude-code/claude_code_yolo_alias_with_custom_user.sh

@@ -15,6 +15,7 @@ check "yolo alias in zshrc" bash -c "grep -Fq 'claude --allow-dangerously-skip-p
 check "fish yolo function body" bash -c "test -f ~/.config/fish/functions/yolo.fish && grep -Fq 'claude --allow-dangerously-skip-permissions' ~/.config/fish/functions/yolo.fish"
 check "bashrc owned by current user" bash -c "test \"$(stat -c '%U' ~/.bashrc)\" = \"$(whoami)\""
 check "zshrc owned by current user" bash -c "test \"$(stat -c '%U' ~/.zshrc)\" = \"$(whoami)\""
+check "fish functions dir owned by current user" bash -c "test \"$(stat -c '%U' ~/.config/fish/functions)\" = \"$(whoami)\""
 check "fish function owned by current user" bash -c "test \"$(stat -c '%U' ~/.config/fish/functions/yolo.fish)\" = \"$(whoami)\""
 check "yolo resolves in bash" bash -ic "type yolo"