llms/googleai: return error instead of panicking on system-only message list#1508
Closed
SAY-5 wants to merge 1 commit into
Closed
llms/googleai: return error instead of panicking on system-only message list#1508SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…ge list Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Author
|
Superseded by #1509, which folds the regression test into the existing googleai_unit_test.go instead of adding a separate file. Closing this one to avoid a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1507
When a message list contains only system messages,
generateFromMessagesbuilds an emptyhistory(every system message is consumed intomodel.SystemInstructionandcontinued), then indexeshistory[n-1]withn == 0and panics withindex out of range [-1].This adds a length check that returns a new
ErrNoRequestMessagesentinel before the index, so callers get an error rather than a panic. Covered by a unit test that drives a system-only list throughgenerateFromMessages.PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.