Add setCreated() to Meta#2
Open
rhertogh wants to merge 1 commit intotmilos:masterfrom
Open
Conversation
Implemented setter for `Meta::$created`
tmilos
requested changes
Nov 16, 2019
Owner
tmilos
left a comment
tmilos
left a comment
There was a problem hiding this comment.
👎 Build have failed.
- php-cs-fixer whitespace
| { | ||
| $this->created = $created; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Build have failed. php-cs-fixer is complaining about whitespace in this line
Contributor
Author
There was a problem hiding this comment.
That's strange, I copied the code from setLastModified() and only changed the names.
Could you please provide the exact message from php-cs-fixer?
Owner
There was a problem hiding this comment.
Click the red link below that says Travis failed, and find the php 7 build where php cs fixer is executed and you'll see the error message in the build log
https://travis-ci.org/tmilos/scim-schema/jobs/612621460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented setter for
Meta::$created