refactor: update logging format to use %-style for consistency

Author: tmunzer-AIDE

src/mistapi/__api_session.py

@@ -308,7 +308,7 @@ def _load_env(self, env_file=None) -> None:
                     os.path.expanduser("~"), env_file.replace("~/", "")
                 )
             env_file = os.path.abspath(env_file)
-            CONSOLE.debug(f"Loading settings from {env_file}")
+            CONSOLE.debug("Loading settings from %s", env_file)
             LOGGER.debug("apisession:_load_env:loading settings from %s", env_file)
             dotenv_path = Path(env_file)
             load_dotenv(dotenv_path=dotenv_path, override=True)
@@ -389,10 +389,10 @@ def set_cloud(self, cloud_uri: str) -> None:
             LOGGER.debug(
                 "apisession:set_cloud:Mist Cloud configured to %s", self._cloud_uri
             )
-            CONSOLE.debug(f"Mist Cloud configured to {self._cloud_uri}")
+            CONSOLE.debug("Mist Cloud configured to %s", self._cloud_uri)
         else:
             LOGGER.error("apisession:set_cloud: %s is not valid", cloud_uri)
-            CONSOLE.error(f"{cloud_uri} is not valid")
+            CONSOLE.error("%s is not valid", cloud_uri)
 
     def get_cloud(self):
         """
@@ -467,7 +467,7 @@ def set_email(self, email: str | None = None) -> None:
         else:
             self.email = input("Login: ")
         LOGGER.info("apisession:set_email:email configured to %s", self.email)
-        CONSOLE.debug(f"Email configured to {self.email}")
+        CONSOLE.debug("Email configured to %s", self.email)
 
     def set_password(self, password: str | None = None) -> None:
         """
@@ -713,7 +713,7 @@ def _process_login(self, retry: bool = True) -> str | None:
                 LOGGER.error(
                     "apisession:_process_login:authentication failed:%s", error
                 )
-                CONSOLE.error(f"Authentication failed: {error}\r\n")
+                CONSOLE.error("Authentication failed: %s\r\n", error)
                 self.email = None
                 self._password = None
                 LOGGER.info(

src/mistapi/__logger.py

@@ -150,60 +150,31 @@ def sanitize(self, data) -> str:
         sanitized_data = self.sensitive_pattern.sub(r'\1"******"', data_str)
         return sanitized_data
 
-    def critical(self, message) -> None:
-        """
-        Docstring for critical
+    def _format(self, message, args) -> str:
+        """Apply %-style formatting if args are provided, then sanitize."""
+        if args:
+            message = str(message) % args
+        return self.sanitize(message)
 
-        :param self: Description
-        :param message: Description
-        :type message: str
-        """
+    def critical(self, message, *args) -> None:
         if self.level <= 50 and self.level > 0:
-            print(f"[{magenta('CRITICAL ')}] {self.sanitize(message)}")
-
-    def error(self, message) -> None:
-        """
-        Docstring for error
+            print(f"[{magenta('CRITICAL ')}] {self._format(message, args)}")
 
-        :param self: Description
-        :param message: Description
-        :type message: str
-        """
+    def error(self, message, *args) -> None:
         if self.level <= 40 and self.level > 0:
-            print(f"[{red('  ERROR  ')}] {self.sanitize(message)}")
-
-    def warning(self, message) -> None:
-        """
-        Docstring for warning
+            print(f"[{red('  ERROR  ')}] {self._format(message, args)}")
 
-        :param self: Description
-        :param message: Description
-        :type message: str
-        """
+    def warning(self, message, *args) -> None:
         if self.level <= 30 and self.level > 0:
-            print(f"[{yellow(' WARNING ')}] {self.sanitize(message)}")
-
-    def info(self, message) -> None:
-        """
-        Docstring for info
+            print(f"[{yellow(' WARNING ')}] {self._format(message, args)}")
 
-        :param self: Description
-        :param message: Description
-        :type message: str
-        """
+    def info(self, message, *args) -> None:
         if self.level <= 20 and self.level > 0:
-            print(f"[{green('  INFO   ')}] {self.sanitize(message)}")
+            print(f"[{green('  INFO   ')}] {self._format(message, args)}")
 
-    def debug(self, message) -> None:
-        """
-        Docstring for debug
-
-        :param self: Description
-        :param message: Description
-        :type message: str
-        """
+    def debug(self, message, *args) -> None:
         if self.level <= 10 and self.level > 0:
-            print(f"[{white('DEBUG  ')}] {self.sanitize(message)}")
+            print(f"[{white('DEBUG  ')}] {self._format(message, args)}")
 
     def _set_log_level(
         self, console_log_level: int = 20, logging_log_level: int = 10