Drop test_local_timeout test case

The local timeout test was introduce in
f30be3b as a wait to check that
connection timeouts work. However, it uses a pretty flaky setup to begin
with, requiring manual `iptables` rules in CI, and it leans on a dummy
server implementation that doesn't actually do anything besides
accepting the connection.

However, as with protocol v1.6 we now only consider the connection
successful (and for now return the `Client`) if the counterparty
responded to our version negotiation, we're now incompatible with the
dummy setup of `test_local_timeout`. Since I'm not sure how solid and
important the specific test coverage is to begin with, I here opted to
just drop the test case.

Author: tnull

.github/workflows/cont_integration.yml

@@ -30,10 +30,6 @@ jobs:
           toolchain: ${{ matrix.rust }}
       - name: Test
         run: cargo test --verbose --all-features
-      - name: Setup iptables for the timeout test
-        run: sudo ip6tables -I INPUT 1 -p tcp -d ::1 --dport 60000 -j DROP
-      - name: Timeout test
-        run: cargo test -- --ignored test_local_timeout
       - run: cargo check --verbose --features=use-openssl
       - run: cargo check --verbose --no-default-features --features=proxy
       - run: cargo check --verbose --no-default-features --features=minimal

src/client.rs

@@ -412,54 +412,4 @@ mod tests {
 
         assert!(!exhausted)
     }
-
-    #[test]
-    #[ignore]
-    fn test_local_timeout() {
-        // This test assumes a couple things:
-        // - that `localhost` is resolved to two IP addresses, `127.0.0.1` and `::1` (with the v6
-        //   one having higher priority)
-        // - that the system silently drops packets to `[::1]:60000` or a different port if
-        //   specified through `TEST_ELECTRUM_TIMEOUT_PORT`
-        //
-        //   this can be setup with: ip6tables -I INPUT 1 -p tcp -d ::1 --dport 60000 -j DROP
-        //   and removed with:       ip6tables -D INPUT -p tcp -d ::1 --dport 60000 -j DROP
-        //
-        // The test tries to create a client to `localhost` and expects it to succeed, but only
-        // after at least 2 seconds have passed which is roughly the timeout time for the first
-        // try.
-
-        use std::net::TcpListener;
-        use std::sync::mpsc::channel;
-        use std::time::{Duration, Instant};
-
-        let endpoint =
-            std::env::var("TEST_ELECTRUM_TIMEOUT_PORT").unwrap_or("localhost:60000".into());
-        let (sender, receiver) = channel();
-
-        std::thread::spawn(move || {
-            let listener = TcpListener::bind("127.0.0.1:60000").unwrap();
-            sender.send(()).unwrap();
-
-            for _stream in listener.incoming() {
-                std::thread::sleep(Duration::from_secs(60))
-            }
-        });
-
-        receiver
-            .recv_timeout(Duration::from_secs(5))
-            .expect("Can't start local listener");
-
-        let now = Instant::now();
-        let client = Client::from_config(
-            &endpoint,
-            crate::config::ConfigBuilder::new()
-                .timeout(Some(Duration::from_secs(5)))
-                .build(),
-        );
-        let elapsed = now.elapsed();
-
-        assert!(client.is_ok());
-        assert!(elapsed > Duration::from_secs(2));
-    }
 }