fix(build): remove shell:true from spawnSync so paths with spaces work on Windows#694
Draft
tobi wants to merge 1 commit into
Draft
fix(build): remove shell:true from spawnSync so paths with spaces work on Windows#694tobi wants to merge 1 commit into
tobi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #681
Root cause
scripts/build.mjs'srun()helper passedshell: process.platform === 'win32'tospawnSync. On Windows, this hands the command tocmd.exeunquoted, so a Node install atC:\Program Files\nodejs\node.exegets split at the space —cmd.exetries to executeC:\Programand fails silently (exit code not propagated). Result:dist/is never produced, butnpm run buildreports success.Fix
shell: false.spawnSyncwith a binary path + args array has never needed shell mode — that's only for passing a shell command string. The binary is invoked directly.