Lints and formatting

Author: tschwarzinger

datafusion-examples/examples/extension_types/event_id.rs

@@ -67,18 +67,10 @@ async fn register_events_table(ctx: &SessionContext) -> Result<DataFrame> {
         schema,
         vec![
             Arc::new(UInt32Array::from(vec![
-                20_01_000000,
-                20_01_000001,
-                21_03_000000,
-                21_03_000001,
-                21_03_000002,
+                2001000000, 2001000001, 2103000000, 2103000001, 2103000002,
             ])),
             Arc::new(UInt32Array::from(vec![
-                2020_01_0000,
-                2020_01_0001,
-                2021_03_0000,
-                2021_03_0001,
-                2021_03_0002,
+                2020010000, 2020010001, 2021030000, 2021030001, 2021030002,
             ])),
             Arc::new(StringArray::from(vec![
                 "First Event Jan 2020",
@@ -167,8 +159,7 @@ impl ExtensionType for EventIdExtensionType {
                 "short" => Ok(IdYearMode::Short),
                 "long" => Ok(IdYearMode::Long),
                 _ => Err(ArrowError::InvalidArgumentError(format!(
-                    "Invalid metadata for event id type: {}",
-                    metadata
+                    "Invalid metadata for event id type: {metadata}"
                 ))),
             },
         }
@@ -256,7 +247,7 @@ impl DisplayIndex for EventIdDisplayIndex<'_> {
                 let month = rest % 100;
                 let year = rest / 100;
 
-                write!(f, "{:02}-{:02}-{:06}", year, month, counter)?;
+                write!(f, "{year:02}-{month:02}-{counter:06}")?;
             }
             IdYearMode::Long => {
                 // Format: YYYY-MM-CCCC
@@ -269,7 +260,7 @@ impl DisplayIndex for EventIdDisplayIndex<'_> {
                 let month = rest % 100;
                 let year = rest / 100;
 
-                write!(f, "{:04}-{:02}-{:04}", year, month, counter)?;
+                write!(f, "{year:04}-{month:02}-{counter:04}")?;
             }
         }
         Ok(())

datafusion/common/Cargo.toml

@@ -66,8 +66,8 @@ apache-avro = { workspace = true, features = [
     "zstandard",
 ], optional = true }
 arrow = { workspace = true }
-arrow-schema = { workspace = true, features = ["canonical_extension_types"] }
 arrow-ipc = { workspace = true }
+arrow-schema = { workspace = true, features = ["canonical_extension_types"] }
 chrono = { workspace = true }
 half = { workspace = true }
 hashbrown = { workspace = true }

datafusion/common/src/types/extension.rs

@@ -32,10 +32,10 @@ pub type DFExtensionTypeRef = Arc<dyn DFExtensionType>;
 /// from these operations. The extension type mechanism allows users to define how these operations
 /// apply to a particular extension type.
 ///
-/// For example, adding two values of [`DataType::Int64`] is a sensible thing to do. However, if the
-/// same column is annotated with an extension type like `custom.id`, the correct interpretation of
-/// a column changes. Adding together two `custom.id` values, even though they are stored as
-/// integers, may no longer make sense.
+/// For example, adding two values of [`Int64`](arrow::datatypes::DataType::Int64) is a sensible
+/// thing to do. However, if the same column is annotated with an extension type like `custom.id`,
+/// the correct interpretation of a column changes. Adding together two `custom.id` values, even
+/// though they are stored as integers, may no longer make sense.
 ///
 /// Note that DataFusion's extension type support is still young and therefore might not cover all
 /// relevant use cases. Currently, the following operations can be customized:

datafusion/expr/src/registry.rs

@@ -258,7 +258,11 @@ pub trait ExtensionTypeRegistration: Debug + Send + Sync {
 /// A cheaply cloneable pointer to an [ExtensionTypeRegistry].
 pub type ExtensionTypeRegistryRef = Arc<dyn ExtensionTypeRegistry>;
 
-/// Supports registering custom [LogicalType]s, including native types.
+/// Manages [`ExtensionTypeRegistration`]s, which allow users to register custom behavior for
+/// extension types.
+///
+/// Each registration is connected to the extension type name, which can also be looked up to get
+/// the registration.
 pub trait ExtensionTypeRegistry: Debug + Send + Sync {
     /// Returns a reference to registration of an extension type named `name`.
     ///