first version of IDENTIFIER

Author: fivetran-kwoodbeck

sqlglot-integration-tests

@@ -1789,7 +1789,13 @@ class JoinHint(Expression):
 
 
 class Identifier(Expression):
-    arg_types = {"this": True, "quoted": False, "global_": False, "temporary": False}
+    arg_types = {
+        "this": True,
+        "quoted": False,
+        "global_": False,
+        "temporary": False,
+        "identifier_func": False,
+    }
     is_primitive = True
     _hash_raw_args = True
 

sqlglot/expressions/core.py

@@ -4600,3 +4600,13 @@ def uuid_sql(self, expression: exp.Uuid) -> str:
             return self.sql(result)
 
         return super().uuid_sql(expression)
+
+    def identifier_sql(self, expression: exp.Identifier) -> str:
+        if expression.args.get("identifier_func"):
+            parts = expression.name.split(".")
+            if len(parts) > 1:
+                result: exp.Expr = exp.to_identifier(parts[0])
+                for part in parts[1:]:
+                    result = exp.Dot(this=result, expression=exp.to_identifier(part))
+                return self.sql(result)
+        return super().identifier_sql(expression)

sqlglot/generators/duckdb.py

@@ -616,6 +616,12 @@ class SnowflakeGenerator(generator.Generator):
         ),
     }
 
+    def identifier_sql(self, expression: exp.Identifier) -> str:
+        if expression.args.get("identifier_func"):
+            name = f'"{expression.name}"' if expression.quoted else expression.name
+            return self.func("IDENTIFIER", exp.Literal.string(name))
+        return super().identifier_sql(expression)
+
     def sortarray_sql(self, expression: exp.SortArray) -> str:
         asc = expression.args.get("asc")
         nulls_first = expression.args.get("nulls_first")

sqlglot/generators/snowflake.py

@@ -733,6 +733,7 @@ class SnowflakeParser(parser.Parser):
         **parser.Parser.FUNCTION_PARSERS,
         "DATE_PART": lambda self: self._parse_date_part(),
         "DIRECTORY": lambda self: self._parse_directory(),
+        "IDENTIFIER": lambda self: self._parse_identifier_function(),
         "OBJECT_CONSTRUCT_KEEP_NULL": lambda self: self._parse_json_object(),
         "LISTAGG": lambda self: self._parse_string_agg(),
         "SEMANTIC_VIEW": lambda self: self._parse_semantic_view(),
@@ -1121,6 +1122,22 @@ def _parse_table(
 
         return table
 
+    def _fold_identifier_literal(self, arg: exp.Expr | None) -> exp.Expr:
+        if arg and arg.is_string:
+            inner = arg.to_py()
+            if len(inner) >= 2 and inner.startswith('"') and inner.endswith('"'):
+                return exp.Identifier(this=inner[1:-1], quoted=True, identifier_func=True)
+            return exp.Identifier(this=inner, identifier_func=True)
+        return self.expression(exp.Anonymous(this="IDENTIFIER", expressions=[arg]))
+
+    def _parse_identifier_function(self) -> exp.Expr:
+        arg = self._parse_string()
+        if not arg and (self._advance_any() or self._match_set(self.ID_VAR_TOKENS)):
+            quoted = self._prev.token_type == TokenType.STRING
+            arg = self._identifier_expression(quoted=quoted)
+        self._match_r_paren()
+        return self._fold_identifier_literal(arg)
+
     def _parse_id_var(
         self,
         any_token: bool = True,
@@ -1131,7 +1148,7 @@ def _parse_id_var(
                 super()._parse_id_var(any_token=any_token, tokens=tokens) or self._parse_string()
             )
             self._match_r_paren()
-            return self.expression(exp.Anonymous(this="IDENTIFIER", expressions=[identifier]))
+            return self._fold_identifier_literal(identifier)
 
         return super()._parse_id_var(any_token=any_token, tokens=tokens)