feat(snowflake)!: Transpilation support for TO_DECIMAL, TO_NUMBER,NUMERIC#7315
Merged
georgesittas merged 11 commits intomainfrom Apr 6, 2026
Merged
feat(snowflake)!: Transpilation support for TO_DECIMAL, TO_NUMBER,NUMERIC#7315georgesittas merged 11 commits intomainfrom
georgesittas merged 11 commits intomainfrom
Conversation
fivetran-ashashankar
changed the title
| join_cols = [col for col in cond.find_all(exp.Column) if col.args.get("join_mark")] | ||
|
|
||
| left_join_table = set(col.table for col in join_cols) | ||
| if not left_join_table: |
Collaborator
Author
There was a problem hiding this comment.
make style formatter modified the transforms.py
sqlglot/dialects/duckdb.py
Outdated
| @@ -4181,6 +4181,84 @@ def strtok_sql(self, expression: exp.Strtok) -> str: | |||
|
|
|||
| return self.function_fallback_sql(expression) | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
Snowflake: TO_NUMBER(expr) defaults to NUMBER(38, 0) -> truncates decimals -> BIGINT
Oracle/others: TO_NUMBER(expr) defaults to NUMBER -> keeps decimals -> DOUBLE
Working on handling this difference. should I use is_snowflake here.
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 109548 total, 107859 passed (pass rate: 98.5%), sqlglot version: sqlglot:RD-1069319_TO_NUMBER_DECIMAL_NUMERIC: 108302 total, 107081 passed (pass rate: 98.9%), sqlglot version: Transitions: ✅ 1 test(s) passed |
geooo109
reviewed
Mar 18, 2026
fivetran-ashashankar
force-pushed
the
RD-1069319_TO_NUMBER_DECIMAL_NUMERIC
branch
from
3264deb to
b285974
Compare
geooo109
reviewed
Mar 26, 2026
Collaborator
There was a problem hiding this comment.
What happened to the rest of the commetns / cases like #7315 (comment) ? (update(edit: no need to resolve these comments for now))
geooo109
force-pushed
the
RD-1069319_TO_NUMBER_DECIMAL_NUMERIC
branch
from
9d9c9f4 to
2ddaef6
Compare
georgesittas
approved these changes
Mar 27, 2026
georgesittas
approved these changes
Mar 27, 2026
Collaborator
|
/integration-tests |
Collaborator
|
Let's not merge this until we figure out the test failures. |
Collaborator
|
/integration-tests |
georgesittas
force-pushed
the
RD-1069319_TO_NUMBER_DECIMAL_NUMERIC
branch
from
85d9b59 to
4806358
Compare
Signed-off-by: George Sittas <giwrgos.sittas@gmail.com>
georgesittas
force-pushed
the
RD-1069319_TO_NUMBER_DECIMAL_NUMERIC
branch
from
697cb76 to
7944560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.