feat(snowflake): support properties before column definitions in CREATE statements#7787
Merged
geooo109 merged 4 commits intoJun 24, 2026
Merged
Conversation
geooo109
reviewed
Jun 24, 2026
geooo109
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR nice work, let's refactor it using my suggestion.
geooo109
reviewed
Jun 24, 2026
georgesittas
approved these changes
Jun 24, 2026
geooo109
reviewed
Jun 24, 2026
geooo109
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snowflake, in
CREATEstatements, acceptsKEY = VALUEproperties both after and before the column definitions, example:Both versions of the above example are valid, but currently passing parameters before column definitions fail to parse. This PR aims to fix this by overriding
_parse_property_beforeto parse such properties.As usual, happy to receive feedback and guidance to follow up.