Skip to content

fix(optimizer): Quotation issue in canonicalize_internal_names #7795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fivetran-kwoodbeck wants to merge 1 commit into from
+5 −4
Closed

fix(optimizer): Quotation issue in canonicalize_internal_names #7795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlglot-integration-tests
Open in desktop
Submodule sqlglot-integration-tests updated from f0c1c9 to 21043c
7 changes: 4 additions & 3 deletions sqlglot/optimizer/canonicalize_internal_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,11 @@ def _canon(ident: exp.Identifier, name: str) -> None:

scope_outputs[id(scope_expr)] = output_map

# Unqualified alias references (ORDER BY a, HAVING a > 5, ...)
# Unqualified alias references (ORDER BY a, HAVING a > 5, ...).
for col in find_all_in_scope(scope_expr, exp.Column):
if not col.table and col.name in output_map:
_canon(col.this, output_map[col.name])
# Only rewrite when the alias is actually being renamed
if not col.table and (canon := output_map.get(col.name)) and canon != col.name:
_canon(col.this, canon)

# UBN matches branches by original alias. When both branches are internal
# and aliased to distinct _cN, matching originals land on different slots
Expand Down
Loading