feat(typing): add databricks type inference module for REGEXP_COUNT, REGEXP_EXTRACT_ALL#7797
Open
fivetran-amrutabhimsenayachit wants to merge 1 commit into
Open
feat(typing): add databricks type inference module for REGEXP_COUNT, REGEXP_EXTRACT_ALL#7797fivetran-amrutabhimsenayachit wants to merge 1 commit into
fivetran-amrutabhimsenayachit wants to merge 1 commit into
Conversation
…REGEXP_EXTRACT_ALL
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing: Overallmain: 192428 total, 153523 passed (pass rate: 79.8%) sqlglot:type-inference-batch-1: 180234 total, 142378 passed (pass rate: 79.0%) Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ All tests passed |
geooo109
reviewed
Jun 26, 2026
Comment on lines
+15
to
+18
| exp_type: {"annotator": lambda self, e: self._annotate_by_args(e, "this", array=True)} | ||
| for exp_type in { | ||
| exp.RegexpExtractAll, | ||
| } |
Collaborator
There was a problem hiding this comment.
Do we need annotate_by_args here? The type is always ARRAY<STRING>, so let's just annotate it by setting the type directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Databricks type inference support for REGEXP_COUNT (INT) and REGEXP_EXTRACT_ALL (ARRAY), and fixture coverage for REGEXP, REGEXP_COUNT, and REGEXP_EXTRACT_ALL.
Tickets
Test plan
make style— PASSmake unit— PASS