chore: use HTTPS repository metadata#452
Open
Uomocapra wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package currently points npm metadata at the SSH style GitHub URL. This switches it to the public HTTPS form:
git+https://github.com/toddbluhm/env-cmd.git.No runtime code, dependencies, or package exports are changed.
Validation
I checked the change with
node -e "const p=require('./package.json'); if (p.repository.url !== 'git+https://github.com/toddbluhm/env-cmd.git') throw new Error(p.repository.url); console.log('metadata ok');",npm pack --dry-run --ignore-scripts --json, andnpm run lint.I also tried
npm run build, but the current unlocked install resolves an unrelated type mismatch between@types/sinonand@sinonjs/fake-timers.