fix(shortcut): now user can increase the size of text using command#14922
fix(shortcut): now user can increase the size of text using command#14922ZAKIURREHMAN wants to merge 2 commits into
Conversation
… option +[, as well decrease
📝 WalkthroughWalkthroughNoteKeymap adds a new private helper ChangesHeading Level Adjustment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@blocksuite/affine/blocks/note/src/note-keymap.ts`:
- Around line 250-257: The command currently applies a single props.type
(updates[0].nextType) to all selected blocks, overriding per-block computations;
change the payload so each selected block carries its own props with its
computed nextType. Specifically, replace the single props field and simple
selectedBlocks array with a selectedBlocks array of objects like {
blockComponent: u.blockComponent, props: { type: u.nextType } } (constructed
from updates.map(...)) when calling
this._std.command.chain().pipe(updateBlockType, ...), so updateBlockType
receives per-block props instead of a global props.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5921c5dc-9f72-410d-80d3-25848a62cbd6
📒 Files selected for processing (1)
blocksuite/affine/blocks/note/src/note-keymap.ts
now user can increase the size of text using command +option +[, as well decrease. #14838
Summary by CodeRabbit