Release SDK updates#451
Merged
Merged
Conversation
Stainless-Generated-From: 40d744a6a4a807b2180882953696ff38d0bc74cc
Broly Security ScanNote Summary 7 actionable finding(s) in this PR
5 highest-priority actionable rows in the table below (critical/high first, then top medium).
Dismiss false positivesEach dismissable row has a Dismiss key (
Note Re-scan this PR anytime with
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Stainless-Generated-From: 1d5c88ae86529cdbe0347cc071cbea0df49b4769
`tg beta clusters ssh` authenticates entirely via the cluster's Dex OIDC flow + step-ca signed SSH certificate — it makes no Together API calls. It used to work with no API key, but #25 added an unconditional `_resolve_project_id` (whoami()) to the global launcher that runs before every command dispatches, so the keyless ssh command started requiring a valid API key. Detect the command via preparse_tokens before creating the client and skip `_create_client` + the whoami() for an allowlist of out-of-band-auth commands (currently just `clusters ssh`). The client is None on that path; ssh() doesn't take `config` so nothing dereferences it, and the finally-block close() is guarded. Every API-backed command keeps its existing api-key gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ng clean - beta clusters ssh: disable host-key verification on the second hop (bastion -> target). Cluster hosts are ephemeral (CAPI-reprovisioned, cert-based user auth) so their host keys aren't pinned; trust is the step-ca user certificate. First hop (client -> bastion) keeps StrictHostKeyChecking=ask. Drops the now-unused known_hosts_path. - Rework the keyless-ssh fix to keep CLIConfig.client non-Optional: add require_api_key to _create_client (waived for no-auth commands) and skip the whoami() there, instead of typing client Optional (which rippled union-attr errors across ~80 API-backed call sites). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…osts_path Existing _ssh_command/_ssh_config_entry tests still passed the removed known_hosts_path arg and asserted the old StrictHostKeyChecking=ask / known_hosts second hop (pyright: 'Expected 6 positional arguments'). Update them to the new signature + assert the second hop is StrictHostKeyChecking=no / UserKnownHostsFile=/dev/null while the first hop (in ProxyCommand) stays =ask. Fixes CI lint (pyright). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fix(cli): [TCL-7938] keyless OIDC `beta clusters ssh` + insecure second hop
sagrawal-byte
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cac9173 docs: expose fine-tune artifact ids