Merge pull request #44 from toggle-corp/feature/settings-typed

### 🚀 Features

- *(lint)* Enable reportImplicitOverride
- *(standup)* Add DailyUserStandup model and Slack-related user fields
- *(slack)* Add Slack bot configuration and utility class
- *(standup)* Automate daily standup coordination and Slack messaging
- *(cli)* Add management commands and cron jobs for standup and Slack sync

### 🐛 Bug Fixes

- *(dev)* Exempt GraphiQL view from CSRF in debug mode

### 🚜 Refactor

- Centralize settings access via typed config module
- *(sso)* Update ui, css theming, and login session expiry indicator

### 🧪 Testing

- *(standup,user)* Add tests for standup tasks, CLI commands, and Slack sync

### ⚙️ Miscellaneous Tasks

- *(helm)* Update django-app chart dependency to v0.1.1

Author: thenav56

apps/common/admin.py

@@ -22,6 +22,7 @@ def has_delete_permission(self, request, obj=None):
 
 
 class UserResourceAdmin(admin.ModelAdmin):
+    @typing.override
     def get_list_display(self, request):
         list_display = super().get_list_display(request)
         for field in ["created_by", "modified_by"]:
@@ -32,6 +33,7 @@ def get_list_display(self, request):
                 ]
         return list_display
 
+    @typing.override
     def get_readonly_fields(self, *args, **kwargs):
         readonly_fields = super().get_readonly_fields(*args, **kwargs)  # type: ignore[reportAttributeAccessIssue]
         return [
@@ -47,12 +49,14 @@ def get_readonly_fields(self, *args, **kwargs):
             ),
         ]
 
+    @typing.override
     def save_model(self, request, obj, form, change):
         if not change:
             obj.created_by = request.user
         obj.modified_by = request.user
         super().save_model(request, obj, form, change)  # type: ignore[reportAttributeAccessIssue]
 
+    @typing.override
     def save_formset(self, request, form, formset, change) -> None:
         if not issubclass(formset.model, UserResource):
             return super().save_formset(request, form, formset, change)
@@ -68,11 +72,13 @@ def save_formset(self, request, form, formset, change) -> None:
             instance.save()
         return None
 
+    @typing.override
     def get_queryset(self, request: HttpRequest) -> models.QuerySet[DjangoModel]:
         return super().get_queryset(request).select_related("created_by", "modified_by")
 
 
 class UserResourceTabularInline(admin.TabularInline):
+    @typing.override
     def get_readonly_fields(self, *args, **kwargs):
         readonly_fields = super().get_readonly_fields(*args, **kwargs)  # type: ignore[reportAttributeAccessIssue]
         return [
@@ -107,6 +113,7 @@ class EventAdmin(VersionAdmin, UserResourceAdmin):
     ordering = ("start_date",)
     actions = [sync_with_google_calendar]
 
+    @typing.override
     def get_readonly_fields(self, *args, **kwargs):
         readonly_fields = super().get_readonly_fields(*args, **kwargs)  # type: ignore[reportAttributeAccessIssue]
         return [
@@ -121,6 +128,7 @@ def get_readonly_fields(self, *args, **kwargs):
             ),
         ]
 
+    @typing.override
     def save_model(self, request, obj, form, change):
         obj.google_calendar_sync_status = Event.GoogleCalendarSyncStatus.PENDING
         super().save_model(request, obj, form, change)

apps/common/factories.py

@@ -0,0 +1,13 @@
+# pyright: reportPrivateImportUsage=false
+# pyright: reportIncompatibleVariableOverride=false
+import factory
+from factory.django import DjangoModelFactory
+
+from .models import Event
+
+
+class EventFactory(DjangoModelFactory):
+    name = factory.Sequence(lambda n: f"Event-{n}")
+
+    class Meta:
+        model = Event

apps/common/management/commands/google_calendar.py

@@ -2,14 +2,18 @@
 import logging
 import typing
 
-from django.conf import settings
 from django.core.management.base import BaseCommand
 
 from apps.common.models import Event
 from apps.common.tasks import sync_event_with_google_calendar
-from apps.common.utils.google_calendar import GoogleCalendarShareRoleType, GoogleServiceAccount
+from apps.common.utils.google_calendar import (
+    GoogleCalendarInitialisationError,
+    GoogleCalendarShareRoleType,
+    GoogleServiceAccount,
+)
 from apps.project.models import Deadline
 from apps.project.tasks import sync_deadline_with_google_calendar
+from main import config
 
 CommandActionType = typing.Literal[
     "list-calendars",
@@ -51,10 +55,18 @@ def list_all_events(service: GoogleServiceAccount, calendar_id, time_min: str |
 class Command(BaseCommand):
     help = "Initialize google calendar"
 
+    def __init__(self, *args, **kwargs):
+        if config.GOOGLE_CALENDAR_ID is None:
+            raise GoogleCalendarInitialisationError("GOOGLE_CALENDAR_ID is not defined")
+
+        self.calendar_id = config.GOOGLE_CALENDAR_ID
+        return super().__init__(*args, **kwargs)
+
     def confirm(self, message: str) -> bool:
         prompt = self.style.NOTICE(f"{message} (y/n): ")
         return input(prompt).strip().lower() == "y"
 
+    @typing.override
     def add_arguments(self, parser):
         subparsers = parser.add_subparsers(dest="action", help="Actions", required=True)
 
@@ -101,7 +113,7 @@ def add_arguments(self, parser):
         subparsers.add_parser("reset-timur-data", help="List calendars")
 
     def list_calendars(self, service: GoogleServiceAccount):
-        logger.info("Action calendar ID: %s", settings.GOOGLE_CALENDAR_ID)
+        logger.info("Action calendar ID: %s", self.calendar_id)
         for cal in service.list_calendar():
             self.stdout.write(json.dumps(cal, indent=2))
 
@@ -118,7 +130,7 @@ def share_calendar(
         role = typing.cast("GoogleCalendarShareRoleType", options["role"])
         calendar_id = typing.cast(
             "str",
-            options.get("calendar_id") or settings.GOOGLE_CALENDAR_ID,
+            options.get("calendar_id") or self.calendar_id,
         )
 
         if role == "owner":
@@ -150,7 +162,7 @@ def list_events(self, service: GoogleServiceAccount, **options):
         time_min = options["time_min"]
         google_calendar_events = list_all_events(
             service,
-            calendar_id=settings.GOOGLE_CALENDAR_ID,
+            calendar_id=self.calendar_id,
             time_min=time_min,
         )
         for result in google_calendar_events:
@@ -161,7 +173,7 @@ def list_colors(self, service: GoogleServiceAccount):
         self.stdout.write(json.dumps(list(results.items()), indent=2))
 
     def list_calendar_access(self, service: GoogleServiceAccount, **options):
-        calendar_id = options.get("calendar_id") or settings.GOOGLE_CALENDAR_ID
+        calendar_id = options.get("calendar_id") or self.calendar_id
         compact = options.get("compact", False)
 
         results = service.service_account.acl().list(calendarId=calendar_id).execute()
@@ -183,7 +195,7 @@ def delete_event(self, service: GoogleServiceAccount, **options):
 
         if self.confirm("Are you sure?"):
             service.service_account.events().delete(
-                calendarId=settings.GOOGLE_CALENDAR_ID,
+                calendarId=self.calendar_id,
                 eventId=event_id,
             ).execute()
 
@@ -252,7 +264,7 @@ def reset_timur_data(self, service: GoogleServiceAccount):
             "deadlines": to_process_deadline_qs.count(),
         }
 
-        calendar_id = settings.GOOGLE_CALENDAR_ID
+        calendar_id = self.calendar_id
         if not self.confirm(f"Are you sure? This will remove {summary}"):
             return
 
@@ -288,6 +300,7 @@ def reset_timur_data(self, service: GoogleServiceAccount):
         self.stdout.write(f" - Success {events_resp}")
         self.stdout.write(f" - Success {deadline_resp}")
 
+    @typing.override
     def handle(self, action: CommandActionType, **options):
         gsc = GoogleServiceAccount()
 

apps/common/management/commands/graphql_schema.py

@@ -1,4 +1,5 @@
 import argparse
+import typing
 
 from django.core.management.base import BaseCommand
 from strawberry.printer import print_schema
@@ -9,13 +10,15 @@
 class Command(BaseCommand):
     help = "Create schema.graphql file"
 
+    @typing.override
     def add_arguments(self, parser):
         parser.add_argument(
             "--out",
             type=argparse.FileType("w"),
             default="schema.graphql",
         )
 
+    @typing.override
     def handle(self, *args, **options):
         file = options["out"]
         file.write(print_schema(schema))

apps/common/management/commands/init_development.py

@@ -1,6 +1,7 @@
 import dataclasses
 import functools
 import json
+import typing
 from argparse import FileType
 from sys import stdin
 
@@ -64,11 +65,13 @@ def wrapper(*args, **kwargs):
 class Command(BaseCommand):
     help = "Generate data for development"
 
+    @typing.override
     def add_arguments(self, parser):
         parser.add_argument("input_file", nargs="?", type=FileType("r"), default=stdin)
         # TODO: Generate time track data
         # TODO: Generate journal data
 
+    @typing.override
     def handle(self, **options):
         if not (settings.DEBUG and settings.ALLOW_DUMMY_DATA_SCRIPT):
             self.stdout.write(

apps/common/management/commands/wait_for_resources.py

@@ -1,5 +1,6 @@
 import signal
 import time
+import typing
 from urllib.parse import urljoin
 
 import requests
@@ -104,6 +105,7 @@ def wait_for_minio(self):
 
         self.stdout.write(self.style.SUCCESS(f"Minio is available after {retry_helper.total_time()} seconds"))
 
+    @typing.override
     def add_arguments(self, parser):
         parser.add_argument(
             "--timeout",
@@ -116,6 +118,7 @@ def add_arguments(self, parser):
         parser.add_argument("--minio", action="store_true", help="Wait for MinIO (S3) storage to be available")
         parser.add_argument("--all", action="store_true", help="Wait for all to be available")
 
+    @typing.override
     def handle(self, **kwargs):
         timeout = kwargs["timeout"]
         _all = kwargs["all"]

apps/common/models.py

@@ -80,13 +80,16 @@ class GoogleCalendarSyncStatus(models.IntegerChoices):
     get_type_display: typing.Callable[..., str]
     get_google_calendar_sync_status_display: typing.Callable[..., str]
 
+    @typing.override
     def __str__(self):
-        return self.name
+        return f"{self.name} - {self.get_type_display()}"
 
+    @typing.override
     def save(self, *args, **kwargs):
         self.reload_cache()
         return super().save(*args, **kwargs)
 
+    @typing.override
     def delete(self, *args, **kwargs):
         from apps.common.tasks import delete_event_from_google_calendar
 
@@ -106,6 +109,7 @@ def dates_check(self):
         if self.start_date > self.end_date:
             raise ValidationError(_("Start date can't be greater then End date"))
 
+    @typing.override
     def clean(self):
         super().clean()
         self.dates_check()
@@ -177,6 +181,28 @@ def aget_last_working_date(
     ) -> datetime.date:  # type: ignore[reportReturnType]
         return cls.get_last_working_date(now_date, skip_dates=skip_dates, offset_count=offset_count)
 
+    @classmethod
+    def get_next_working_date(
+        cls,
+        now_date: datetime.date,
+        skip_dates: list[datetime.date] | None = None,
+        offset_count: int | None = None,
+    ) -> datetime.date:  # type: ignore[reportReturnType]
+        # TODO: Add test
+        dates_to_skip = set(cls.get_relative_event_dates())
+        if skip_dates:
+            dates_to_skip.update(skip_dates)
+        found_count = 0
+        for x in range(30):  # Create a 1 month window, Should be enough
+            date = now_date + datetime.timedelta(days=x)
+            if cls.is_weekend(date) or date in dates_to_skip:
+                continue
+            if offset_count is not None and found_count < offset_count:
+                found_count += 1
+                continue
+            return date
+        return timezone.now()  # XXX: Fallback to now
+
     @classmethod
     def get_relative_non_working_events(cls) -> models.QuerySet["Event"]:
         """

apps/common/serializers.py

@@ -1,3 +1,5 @@
+import typing
+
 from django.core.exceptions import FieldDoesNotExist
 from rest_framework import serializers
 
@@ -12,13 +14,15 @@ class UserResourceSerializer(serializers.ModelSerializer):
     client_id = StringIDField(required=False)
     version_id = serializers.SerializerMethodField()
 
+    @typing.override
     def create(self, validated_data):
         if "created_by" in self.Meta.model._meta._forward_fields_map:  # type: ignore[reportAttributeAccessIssue]
             validated_data["created_by"] = self.context["request"].user
         if "modified_by" in self.Meta.model._meta._forward_fields_map:  # type: ignore[reportAttributeAccessIssue]
             validated_data["modified_by"] = self.context["request"].user
         return super().create(validated_data)
 
+    @typing.override
     def update(self, instance, validated_data):
         if "modified_by" in self.Meta.model._meta._forward_fields_map:  # type: ignore[reportAttributeAccessIssue]
             validated_data["modified_by"] = self.context["request"].user
@@ -54,6 +58,7 @@ def _get_temp_client_id(self, validated_data):
             # If we don't remove `client_id` from validated_data, then serializer will throw error on update/create
             return validated_data.pop("client_id", None)
 
+    @typing.override
     def create(self, validated_data):
         temp_client_id = self._get_temp_client_id(validated_data)
         instance = super().create(validated_data)
@@ -62,6 +67,7 @@ def create(self, validated_data):
             local_cache.set(self.get_cache_key(instance, self.context["request"]), temp_client_id, 60)
         return instance
 
+    @typing.override
     def update(self, instance, validated_data):
         temp_client_id = self._get_temp_client_id(validated_data)
         instance = super().update(instance, validated_data)