Add manual "Add Pin" dialog and File→Add Pin menu; update player pin …

[amnindersingh12]

Add manual "Add Pin" feature (Closes #40)

• Add modal dialog to add pins by hand: Forms/FrmAddPin.cs
• Add "Add Pin..." menu item in File menu and wire click handler:
  • Forms/FrmMain.Designer.cs (add addPinToolStripMenuItem)
  • Forms/FrmMain.cs (AddPinToolStripMenuItem_Click to show dialog, update playerObject lists, update counts, avoid duplicates, enable Save)
• Include new form in project file: SoG_Savegame_Editor.csproj
• Fix enum name collision by qualifying System.Enum usage in FrmAddPin.cs

Behavior:

• User can open File → Add Pin..., select a SogPin and target list (PinsSeen, PinsOnShelf, PinsEquipped, PinsLatest).
• Selected pin is added to the chosen in-memory player list (lazy-init if null), duplicates prevented, counts updated, Save enabled.

Fixes: #40

[tolik518]

Hey, thanks for the PR!

Your implementation vastly differs from the current structure of the tool, though.
Please add a new tab for pins, like for every other setting instead of using a dedicated Form.

[amnindersingh12]

@tolik518 Made some chages please have a look at it !!

[tolik518]

@amnindersingh12 Looks good to me on the first glance :)
The only thing that's now missing is the following:

If the user marks an item as equipped, it should be automatically be added as seen (you cant equip something you've never seen). Otherwise it looks good and I'll merge after our adjustment!

[tolik518]

Hey @amnindersingh12, can you fix that or should I close the PR?

[Copilot]

Pull Request Overview

This PR adds functionality for manually adding pins to a player's save file through a new "Add Pin" dialog accessible via File → Add Pin menu, addressing issue #40. The changes also include automated tracking of equipped items as "seen" and proper initialization of pin-related UI controls.

Key Changes:

• Added new FrmAddPin form with menu integration for manually adding pins to player lists
• Implemented automatic marking of items as seen when equipped via combo box event handlers
• Initialized pin checklist data sources and added population/serialization logic for all four pin collections

Files not reviewed (1)

• SoG_Savegame_Editor/Forms/FrmMain.Designer.cs: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Calling Clear() on a potentially null list before reassigning defeats the purpose of the null-conditional operator. Either remove line 820 or change line 821 to only assign when null: playerObject.PinsSeen ??= new List<SogPin>(); followed by playerObject.PinsSeen.Clear();

Suggested change

playerObject.PinsSeen?.Clear();

[Copilot]

Calling Clear() on a potentially null list before reassigning defeats the purpose of the null-conditional operator. Either remove line 831 or change line 832 to only assign when null: playerObject.PinsOnShelf ??= new List<SogPin>(); followed by playerObject.PinsOnShelf.Clear();

Suggested change

playerObject.PinsOnShelf?.Clear();

[Copilot]

Calling Clear() on a potentially null list before reassigning defeats the purpose of the null-conditional operator. Either remove line 842 or change line 843 to only assign when null: playerObject.PinsEquipped ??= new List<SogPin>(); followed by playerObject.PinsEquipped.Clear();

Suggested change

playerObject.PinsEquipped?.Clear();

[Copilot]

Calling Clear() on a potentially null list before reassigning defeats the purpose of the null-conditional operator. Either remove line 853 or change line 854 to only assign when null: playerObject.PinsLatest ??= new List<SogPin>(); followed by playerObject.PinsLatest.Clear();

Suggested change

playerObject.PinsLatest?.Clear();

[Copilot]

Consider using cblstItemsSeen.Items.IndexOf(itemName) instead of manually iterating through the items collection, which is more efficient and concise.

Suggested change

	int itemIndex = -1;
	for (int i = 0; i < cblstItemsSeen.Items.Count; i++)
	{
	if (cblstItemsSeen.Items[i].ToString() == itemName)
	{
	itemIndex = i;
	break;
	}
	}
	int itemIndex = cblstItemsSeen.Items.IndexOf(itemName);