Skip to content

Answer:50#1465

Closed
reed756 wants to merge 3 commits into
tomalaforge:mainfrom
reed756:signal-bug
Closed

Answer:50#1465
reed756 wants to merge 3 commits into
tomalaforge:mainfrom
reed756:signal-bug

Conversation

@reed756

@reed756 reed756 commented Mar 28, 2026

Copy link
Copy Markdown

I think the code originally doesn't work because the effect will run once when the first model changes and then will only track changes for that model that changed first, ignoring the others.

@github-actions github-actions Bot added 50 bug signal effect: effect not triggered answer answer labels Mar 28, 2026
@tomalaforge

Copy link
Copy Markdown
Owner

Hello Ram, thanks for sponsoring the project.

have your read my latest article: https://medium.com/p/b0b69804496d
it's on this issue.

your fix might work but it's way to complicated and hard to understand. You can fix it in a very simpler way

@reed756

reed756 commented Mar 30, 2026

Copy link
Copy Markdown
Author

Hello Ram, thanks for sponsoring the project.

have your read my latest article: https://medium.com/p/b0b69804496d it's on this issue.

your fix might work but it's way to complicated and hard to understand. You can fix it in a very simpler way

Hi @tomalaforge, thanks for the review. I've read the article and understand the fix. However, it will still trigger the alert every time you uncheck one of the boxes which doesn't match the acceptance criteria for the challenge. I couldn't think of another way to only trigger the alert when checking one of the boxes, other than having another signal to track the previous number of boxes that have been checked. Then you can compare the current number of boxes checked with the previous number to determine if you should show the alert or not.

@github-actions

Copy link
Copy Markdown

This pull request is stale because it has been open for 15 days with no activity.

@github-actions github-actions Bot added the stale label Apr 20, 2026
@github-actions

Copy link
Copy Markdown

This pull request was closed because it has been inactive for 5 days since being marked as stale.

@github-actions github-actions Bot closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

50 bug signal effect: effect not triggered answer answer stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants