dbt selector logic not working

[aeparshin]

I've tried calling a dbt selector with a DbtRunOperator, but it just ignores my selectors.yml file and makes a 'dbt run' of the full project.

Since DbtRunOperator is not accepting 'selector' as an argument and only accepts 'selector_name' here's how I tried to call it:

from airflow_dbt_python.operators.dbt import (
 DbtRunOperator)

    dbt_run_task1 = DbtRunOperator(
    task_id='dbt_run_task1',
    selector_name=['my_selector'],

I suspect DbtRunOperator should be accepting 'selector' as an argument of string type. I tried to change the source code locally for DbtRunOperator to accept 'selector' and calling it from airflow plugins directory. It worked as expected by running only models listed in the selectors.yml

[tomasfarias]

Hey @aeparshin! Thank you for sharing this issue.

Could you share your source code changes that made this work locally for you?

I would like to first setup a test case to reproduce the issue and then apply your changes. If you want to do a pull request with this yourself, then that's obviously more than welcome 😄! If not, at least seeing your changes would serve as a starting point for me to put up a patch to solve the issue.

[tomasfarias]

Ah I think I see the issue: I think this commit changed selector_name to selector dbt-labs/dbt-core@1809852#diff-f01af78b7eaa1bacc301afa75eea4c7cdbe03064b3913bc2ce3f6bf01d0bc125, but we still use selector_name (even though we support selector in the config level). I think we should just switch to using selector internally and treat selector_name as an alias.

I'll try to reproduce this locally and put up a patch.

[tomasfarias]

Quick update here: I got a local test to pass using a selector after renaming selector_name to selector and treating it as a str instead of list[str]. I think this should solve the issue here, so I will close this issue when the linked PR is merged, with a patch release happening soon after.

This should work on airflow-dbt-python==3.0.2:

from airflow_dbt_python.operators.dbt import (
 DbtRunOperator)

    dbt_run_task1 = DbtRunOperator(
    task_id='dbt_run_task1',
    selector='my_selector',
...

If the issue persist please let me know by re-opening this issue! Thank you!

[aeparshin]

Thanks for a quick reply! But yeah, I basically did the same thing locally, just added 'selector' to accepted operator arguments.