fix: Use selector instead of selector_name#154
Merged
Conversation
Around dbt version 1.5, the selector_name argument got renamed to simply selector. Our configuration already supports it, so we should use it everywhere and treat selector_name as a backwards compatible alias. Moreover, selector is always a string, and not a list of strings as it was typed in the DbtRunOperator.
tomasfarias
marked this pull request as ready for review
June 12, 2025 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Around dbt version 1.5, the selector_name argument got renamed to
simply selector. Our configuration already supports it, so we should
use it everywhere and treat selector_name as a backwards compatible
alias.
Moreover, selector is always a string, and not a list of strings as it
was typed in the DbtRunOperator.