-
-
Notifications
You must be signed in to change notification settings - Fork 41
fix: Support for Airflow 3.1 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
54602e8
chore: Update CI versions
tomasfarias cdfdddb
fix: Specify versions required for Airflow 3.1
tomasfarias 0363fc9
fix: Update import paths according to Airflow versions
tomasfarias 9d868ac
fix: Do not set connection value when empty string
tomasfarias a945e21
fix: Handle xcom push differently in Airflow>=3.1
tomasfarias 769b4a4
fix(examples): Update import path for compatibility
tomasfarias 9014645
fix: Update fixtures
tomasfarias 03dbeeb
fix: Update tests to use new connections
tomasfarias effdac0
fix: Update DAG tests to deal with Airflow database
tomasfarias c6b9dca
fix: Update dependency versions
tomasfarias fc03d50
fix: Pin structlog version as Airflow>=3.1 crashes
tomasfarias d21bbc8
fix: Clean up session usage in tests
tomasfarias 41389a0
fix: Update CI versions
tomasfarias ff59c96
fix: Drop python 3.9 support due to dulwich incompatibility
tomasfarias 8f34a52
fix: Ignore type
tomasfarias 1518a9e
fix: Adjust fixture scope
tomasfarias 6193268
fix: Conditionally import FSHook
tomasfarias 0b526a5
fix: Run git server in thread
tomasfarias f8ee9a7
fix: Remove unused import
tomasfarias 236f463
fix: Ignore a bunch of types
tomasfarias ae9ff67
fix: Only sync dags in Airflow 3.1 or later
tomasfarias 03a2fce
fix: Also use TI for xcom_push in Airflow 3.0
tomasfarias a22e9ab
fix: Attempt to use dag.test() for Airflow 3.0 too
tomasfarias 1b5344f
fix: Also use DAG in taskflow test in Airflow 3.0
tomasfarias 83cfdff
fix: Attempt to also sync DAG in Airflow 3.0
tomasfarias a578b2f
fix: Just run Airflow 3.0 tests like before
tomasfarias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomasfarias Hi! I'm a little confused by this change.
Is there any reason why you specified 3.0 as the minimum version for Python 3.12?
According to the Airflow changelog, support for Python 3.12 was added starting with version 2.9.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I jumped ahead to the next version in our tests: We had 2.8, 3.0, and 3.1. So, I just jumped ahead to 3.0.
We could update the minimum version of Airflow to 2.9 for Python 3.12. It's not covered by our tests, but I think it should be relatively safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#170
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'll try to get everything released soon. I've been travelling this week so releases are a bit delayed.