fix: derive non-marker children synchronously to avoid stale map layers#293
Open
tim-baecker wants to merge 1 commit into
Open
fix: derive non-marker children synchronously to avoid stale map layers#293tim-baecker wants to merge 1 commit into
tim-baecker wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Non-marker children (
Polyline,Overlay, etc.) were stored in React state and only updated inuseEffectafter splittingpropsChildren. When those children were removed from props (e.g. toggling map layers off), native map views could stay on screen even though React no longer rendered them.Solution
Derive non-marker children synchronously with
useMemofrompropsChildren(same rules as before: all children whenclusteringEnabledis false, otherwise everything that is not aMarker). The clusteringuseEffectonly buildsrawDatafrom markers.Notes