Skip to content

harden: add rel="noopener noreferrer" to external target="_blank" links #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SciLor merged 1 commit into from
Jun 7, 2026
Merged

harden: add rel="noopener noreferrer" to external target="_blank" links #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/common/footer/StyledFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const StyledFooter = () => {
? gitHubTCCommitTreeBaseUrl + commitGitSha
: gitHubTCReleasesUrl + "tag/tc_" + versionShort
}
target="_blank"
target="_blank" rel="noopener noreferrer"
>
<HiddenDesktop>
{versionShort} ({commitGitShaShort})
Expand All @@ -112,7 +112,7 @@ export const StyledFooter = () => {
? gitHubTCCommitTreeBaseUrl + latestDevelopSHA
: gitHubTCReleasesUrl + "tag/" + latestReleaseVersion
}
target="_blank"
target="_blank" rel="noopener noreferrer"
style={{
display: "inline-flex",
alignItems: "center",
Expand All @@ -136,7 +136,7 @@ export const StyledFooter = () => {
<b>
<Link
to={gitHubSponsoringUrl}
target="_blank"
target="_blank" rel="noopener noreferrer"
style={{ paddingLeft: 8 }}
>
{t("footer.sponsor")}
Expand Down
2 changes: 1 addition & 1 deletion src/components/community/CommunitySubNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export const CommunitySubNav = () => {
label: (
<Link
to={forumUrl}
target="_blank"
target="_blank" rel="noopener noreferrer"
onClick={() => {
setNavOpen(false);
setSubNavOpen(false);
Expand Down
2 changes: 1 addition & 1 deletion src/components/home/HomeSubNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const HomeSubNav = () => {
label: (
<Link
to={gitHubSponsoringUrl}
target="_blank"
target="_blank" rel="noopener noreferrer"
onClick={() => {
setNavOpen(false);
setSubNavOpen(false);
Expand Down
2 changes: 1 addition & 1 deletion src/components/home/features/Features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const Features = () => {
? gitHubTCCommitTreeBaseUrl + commitGitSha
: gitHubTCReleasesUrl + "tag/tc_" + versionShort
}
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{version.replace(versionShort, "")} {<ExportOutlined />}
</Link>
Expand Down
12 changes: 6 additions & 6 deletions src/components/home/home/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const Home = () => {
? gitHubTCCommitTreeBaseUrl + latestDevelopSHA
: gitHubTCReleasesUrl + "tag/" + latestReleaseVersion
}
target="_blank"
target="_blank" rel="noopener noreferrer"
style={{
display: "inline-flex",
alignItems: "center",
Expand Down Expand Up @@ -178,7 +178,7 @@ export const Home = () => {

<Paragraph>
{t("home.forumIntroPart1")}
<Link to={forumUrl} target="_blank">
<Link to={forumUrl} target="_blank" rel="noopener noreferrer">
{forumUrl} {<ExportOutlined />}
</Link>
{t("home.forumIntroPart2")}
Expand All @@ -200,22 +200,22 @@ export const Home = () => {
<Link to="/community/faq">FAQ</Link>
</li>
<li>
<Link to={gitHubUrl} target="_blank">
<Link to={gitHubUrl} target="_blank" rel="noopener noreferrer">
GitHub {<ExportOutlined />}
</Link>
</li>
<li>
<Link to={telegramGroupUrl} target="_blank">
<Link to={telegramGroupUrl} target="_blank" rel="noopener noreferrer">
Telegram Chat {<ExportOutlined />}
</Link>
</li>
<li>
<Link to={forumUrl} target="_blank">
<Link to={forumUrl} target="_blank" rel="noopener noreferrer">
Discourse Forum {<ExportOutlined />}
</Link>
</li>
<li>
<Link to={wikiUrl} target="_blank">
<Link to={wikiUrl} target="_blank" rel="noopener noreferrer">
TeddyCloud Wiki {<ExportOutlined />}
</Link>
</li>
Expand Down
2 changes: 1 addition & 1 deletion src/components/settings/SettingsSubNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export const SettingsSubNav = () => {
label: (
<Link
to={`${extractBaseUrl(new URL(window.location.href))}/legacy.html`}
target="_blank"
target="_blank" rel="noopener noreferrer"
onClick={() => {
setNavOpen(false);
setSubNavOpen(false);
Expand Down
8 changes: 4 additions & 4 deletions src/components/tonieboxes/boxsetup/OpenBoxGuide.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,19 +120,19 @@ export const OpenBoxGuide: React.FC = () => {
<>
<Paragraph style={{ fontSize: "small" }}>
{t("tonieboxes.boxSetup.openBoxGuide.guideSourcePart1")}{" "}
<Link to={t("tonieboxes.boxSetup.openBoxGuide.link1")} target="_blank">
<Link to={t("tonieboxes.boxSetup.openBoxGuide.link1")} target="_blank" rel="noopener noreferrer">
iFixit[1] {<ExportOutlined />}
</Link>{" "}
{t("tonieboxes.boxSetup.openBoxGuide.guideSourcePart2")}{" "}
<Link to={t("tonieboxes.boxSetup.openBoxGuide.link2")} target="_blank">
<Link to={t("tonieboxes.boxSetup.openBoxGuide.link2")} target="_blank" rel="noopener noreferrer">
iFixit[2] {<ExportOutlined />}
</Link>
. {t("tonieboxes.boxSetup.openBoxGuide.guideSourcePart3")}{" "}
<Link to="https://www.ifixit.com/User/828031/Tobias+Isakeit">
Tobias Isakeit {<ExportOutlined />}
</Link>{" "}
{t("tonieboxes.boxSetup.openBoxGuide.guideSourcePart4")}{" "}
<Link to="https://creativecommons.org/licenses/by-nc-sa/3.0/" target="_blank">
<Link to="https://creativecommons.org/licenses/by-nc-sa/3.0/" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxSetup.openBoxGuide.guideSourceLicense")} {<ExportOutlined />}
</Link>
</Paragraph>
Expand All @@ -143,7 +143,7 @@ export const OpenBoxGuide: React.FC = () => {

<Paragraph>
{t("tonieboxes.boxSetup.openBoxGuide.alternativeGuidelineVideo")}{" "}
<Link to="https://www.youtube.com/watch?v=Cv9ID4-P6_A" target="_blank">
<Link to="https://www.youtube.com/watch?v=Cv9ID4-P6_A" target="_blank" rel="noopener noreferrer">
https://www.youtube.com/watch?v=Cv9ID4-P6_A {<ExportOutlined />}
</Link>
</Paragraph>
Expand Down
6 changes: 3 additions & 3 deletions src/components/tonieboxes/boxsetup/boxsetupoverview/boxsetup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const BoxSetupContent: React.FC = () => {
<ul>
{reachableNewbieGuideUrls.map(({ id, url, title }) => (
<li key={id}>
<a href={url} target="_blank">
<a href={url} target="_blank" rel="noopener noreferrer">
{title} {<ExportOutlined />}
</a>
</li>
Expand Down Expand Up @@ -174,11 +174,11 @@ export const BoxSetupContent: React.FC = () => {

<Paragraph style={{ marginTop: 16 }}>
{t("tonieboxes.boxSetup.boxSetupIntro1")}{" "}
<Link to={forumUrl} target="_blank">
<Link to={forumUrl} target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxSetup.boxSetupIntroForum")}
</Link>{" "}
{t("tonieboxes.boxSetup.boxSetupIntro2")}{" "}
<Link to={telegramGroupUrl} target="_blank">
<Link to={telegramGroupUrl} target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxSetup.boxSetupIntroTelegram")}
</Link>{" "}
{t("tonieboxes.boxSetup.boxSetupIntro3")}
Expand Down
8 changes: 4 additions & 4 deletions src/components/tonieboxes/boxsetup/cc3200/elements/InstallCC3200Tool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function installCC3200Tool(): JSX.Element {
<ul>
<li>
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.pythonText1")}
<Link to="https://www.python.org/downloads/" target="_blank">
<Link to="https://www.python.org/downloads/" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.pythonTextLink")}{" "}
{<ExportOutlined />}
</Link>
Expand All @@ -27,7 +27,7 @@ export function installCC3200Tool(): JSX.Element {
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.gitText1")}
<Link
to="https://git-scm.com/book/en/v2/Getting-Started-Installing-Git"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.gitTextLink")}{" "}
{<ExportOutlined />}
Expand All @@ -36,7 +36,7 @@ export function installCC3200Tool(): JSX.Element {
</li>
<li>
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.pipText1")}
<Link to="https://pip.pypa.io/en/stable/installation/" target="_blank">
<Link to="https://pip.pypa.io/en/stable/installation/" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.pipTextLink")}{" "}
{<ExportOutlined />}
</Link>
Expand All @@ -63,7 +63,7 @@ export function installCC3200Tool(): JSX.Element {
<Paragraph>
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.moreInformation")}
</Paragraph>
<Link to="https://github.com/toniebox-reverse-engineering/cc3200tool" target="_blank">
<Link to="https://github.com/toniebox-reverse-engineering/cc3200tool" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxFlashingCommon.installCC3200Tool.link")} {<ExportOutlined />}
</Link>
</>
Expand Down
4 changes: 2 additions & 2 deletions src/components/tonieboxes/boxsetup/cc3200/steps/Step0Preparations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const Step0Preparations: React.FC<Step0PreparationsProps> = ({ hwTool, on
{t("tonieboxes.cc3200BoxFlashing.esp32C3UartGateway.prepareStep2")}{" "}
<Link
to="https://g3gg0.github.io/ESP32-UART-Gateway/flasher.html"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
Flashing ESP32-C3 {<ExportOutlined />}
</Link>
Expand Down Expand Up @@ -235,7 +235,7 @@ export const Step0Preparations: React.FC<Step0PreparationsProps> = ({ hwTool, on
{t("tonieboxes.cc3200BoxFlashing.connectToTonieboxConnectDebugPortText1")}
<Link
to="https://www.tag-connect.com/product/tc2050-idc-nl-10-pin-no-legs-cable-with-ribbon-connector"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
TC2050-IDC-NL TagConnector {<ExportOutlined />}
</Link>
Expand Down
4 changes: 2 additions & 2 deletions src/components/tonieboxes/boxsetup/cc3200/steps/Step1Bootloader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export const Step1Bootloader: React.FC<Step1PreparationsProps> = ({ hwTool }) =>
{t("tonieboxes.cc3200BoxFlashing.installingBootloader.downloadText1")}
<Link
to="https://github.com/toniebox-reverse-engineering/hackiebox_cfw_ng/releases"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t("tonieboxes.cc3200BoxFlashing.installingBootloader.downloadLink")}{" "}
{<ExportOutlined />}
Expand Down Expand Up @@ -329,7 +329,7 @@ export const Step1Bootloader: React.FC<Step1PreparationsProps> = ({ hwTool }) =>
)}
<Link
to="https://tonies-wiki.revvox.de/docs/custom-firmware/cc3200/hackieboxng-bl/bootloader/"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t(
"tonieboxes.cc3200BoxFlashing.installingBootloader.installingBootloaderStage2.here",
Expand Down
3 changes: 1 addition & 2 deletions src/components/tonieboxes/boxsetup/cc3200/steps/Step3Patches.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ export const Step3Patches: React.FC<CC3200Step3PatchesProps> = ({
<h3>{t("tonieboxes.cc3200BoxFlashing.patches")}</h3>
<a
href="https://tonies-wiki.revvox.de/docs/custom-firmware/cc3200/hackieboxng-bl/ofw-patches/"
target="_blank"
rel="noreferrer"
target="_blank" rel="noopener noreferrer"
>
{t("tonieboxes.cc3200BoxFlashing.patchesMoreInformationLink")} {<ExportOutlined />}
</a>
Expand Down
6 changes: 3 additions & 3 deletions src/components/tonieboxes/boxsetup/cc3200/steps/Step4ApplyingPatches.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export const Step4ApplyingPatches: React.FC = () => {
)}{" "}
<Link
to="https://github.com/toniebox-reverse-engineering/hackiebox_cfw_ng/tree/master/sd-bootloader-ng/bootmanager/sd/revvox/boot/patch"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t(
"tonieboxes.cc3200BoxFlashing.applyingPatchesSection.technicalDetailsCollapse.patchDirectory",
Expand All @@ -218,7 +218,7 @@ export const Step4ApplyingPatches: React.FC = () => {
{", "}
<Link
to="https://tonies-wiki.revvox.de/docs/custom-firmware/cc3200/hackieboxng-bl/ofw-patches/"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t(
"tonieboxes.cc3200BoxFlashing.applyingPatchesSection.technicalDetailsCollapse.patchWiki",
Expand Down Expand Up @@ -349,7 +349,7 @@ export const Step4ApplyingPatches: React.FC = () => {
)}{" "}
<Link
to="https://github.com/toniebox-reverse-engineering/hackiebox_cfw_ng/blob/master/sd-bootloader-ng/bootmanager/sd/revvox/boot/ngCfg.json"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t(
"tonieboxes.cc3200BoxFlashing.applyingPatchesSection.technicalDetailsCollapse.section1_link",
Expand Down
4 changes: 2 additions & 2 deletions src/components/tonieboxes/boxsetup/cc3235/steps/Step0Preparations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const CC3235Step0Preparations: React.FC<Step0PreparationsProps> = ({
<h4>{t("tonieboxes.cc3235BoxFlashing.installSerprogFirmware")}</h4>
<Paragraph>{t("tonieboxes.cc3235BoxFlashing.pico.preparation")}</Paragraph>
<Paragraph>
<Link to="https://github.com/stacksmashing/pico-serprog" target="_blank">
<Link to="https://github.com/stacksmashing/pico-serprog" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.cc3235BoxFlashing.serprogFirmwareLink")} {<ExportOutlined />}
</Link>
</Paragraph>
Expand Down Expand Up @@ -296,7 +296,7 @@ Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub`}
<h4>{t("tonieboxes.cc3235BoxFlashing.installflashromtool")}</h4>
{t("tonieboxes.cc3235BoxFlashing.installflashromtoolText")}
<CodeSnippet language="shell" code={`sudo apt-get install flashrom`} />
<Link to="https://www.flashrom.org/" target="_blank">
<Link to="https://www.flashrom.org/" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.cc3235BoxFlashing.installflashromtoolLink")} {<ExportOutlined />}
</Link>

Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/cc3235/steps/Step1Certificates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const Step1Certificates: React.FC<CC3235Step1CertificatesProps> = ({
{t("tonieboxes.cc3235BoxFlashing.flashCAReplacementDescription1")}{" "}
<Link
to="https://raw.githubusercontent.com/toniebox-reverse-engineering/teddycloud/master/contrib/gencerts.sh"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t("tonieboxes.cc3235BoxFlashing.gencertLinkText")} {<ExportOutlined />}
</Link>{" "}
Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/common/elements/DnsForTeddyCloud.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ uci commit dhcp
<ul style={{ marginBottom: 0 }}>
<li>
{t("tonieboxes.boxFlashingCommon.adguard.moreInformation")}{" "}
<Link to="https://adguard.com/" target="_blank">
<Link to="https://adguard.com/" target="_blank" rel="noopener noreferrer">
https://adguard.com/ {<ExportOutlined />}
</Link>
</li>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/common/modals/AvailableBoxesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const AvailableBoxesModal: React.FC<AvailableBoxesModalProps> = ({
</Paragraph>
<Link
to="https://tonies-wiki.revvox.de/docs/tools/teddycloud/setup/test-troubleshooting/"
target="_blank"
target="_blank" rel="noopener noreferrer"
>
{t("tonieboxes.availableBoxModal.troubleShooting")}
</Link>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/esp32/flashing/steps/Step0Preparations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const Step0Preparations: React.FC<Step0Props> = ({
<ul>
{reachableBackUpUrls.map(({ id, url, title }) => (
<li key={id}>
<a href={url} target="_blank">
<a href={url} target="_blank" rel="noopener noreferrer">
{title} {<ExportOutlined />}
</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/esp32/legacy/steps/Step0Preparations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const Step0Preparations: React.FC = () => {
<h4>{t("tonieboxes.esp32BoxFlashing.legacy.installESPTool")}</h4>
<Paragraph>{t("tonieboxes.esp32BoxFlashing.legacy.installESPToolText")}</Paragraph>
<Paragraph>
<Link to="https://github.com/espressif/esptool" target="_blank">
<Link to="https://github.com/espressif/esptool" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.esp32BoxFlashing.legacy.installESPToolLink")}{" "}
{<ExportOutlined />}
</Link>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tonieboxes/boxsetup/identifyboxversion/IdentifyBoxVersionContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ const MacIdentifyForm: React.FC<MacIdentifyFormProps> = ({
</Button>
<Paragraph style={{ fontSize: "small", marginTop: 16 }}>
{t("tonieboxes.boxSetup.identifyVersion.macvendors")}{" "}
<Link to="https://macvendors.com/" target="_blank">
<Link to="https://macvendors.com/" target="_blank" rel="noopener noreferrer">
{t("tonieboxes.boxSetup.identifyVersion.macvendorsLink")} {<ExportOutlined />}
</Link>
</Paragraph>
Expand Down
Loading