wasm: regenerate taf_encoder for the heap-cap / truncation fix#312
Closed
aflores-qb wants to merge 1 commit into
Closed
wasm: regenerate taf_encoder for the heap-cap / truncation fix#312aflores-qb wants to merge 1 commit into
aflores-qb wants to merge 1 commit into
Conversation
Rebuilds the committed browser TAF encoder from the merged server-side fix (toniebox-reverse-engineering/teddycloud#453), which propagates buffer_write() failures and raises the encoder heap cap 256MB -> 2GB so long recordings no longer produce a silently truncated TAF. Built with `make wasm` (emcc 6.0.0) from teddycloud `develop`, with the exact Makefile flags unchanged. Fixes teddycloud_web#281.
Contributor
|
I've added the emsdk to the submodules and build it this way myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281
Depends on / completes toniebox-reverse-engineering/teddycloud#453 (merged)
What
Regenerates the committed browser TAF encoder (
public/wasm/taf_encoder.{js,wasm}) from the merged server-side fix in teddycloud#453.That fix addresses #281: the encoder grew its output via
buffer_write(), whoserealloc()failure (-1) was ignored at every call site, so a long recording produced a silently truncated TAF reported as success (the reporter saw a 122-min file cut to ~83 MB). The C change propagates the failure and raises the WASM heap cap 256 MB → 2 GB. Since the compiled encoder is committed here as a binary, it must be regenerated for the fix to reach users — that's this PR.Build provenance
make wasm(the repo's existing target) using emcc 6.0.0, from teddyclouddevelopafter #453 merged, with the Makefile's emscripten flags unchanged.js38135→38567 B,wasm332180→332175 B), and exports the same API (createTafEncoder,_taf_encoder_create/encode/finalize/get_buffer/get_size/free); the.wasmmagic is valid (\0asm).Testing note
emscripten/a browser aren't available in CI here, so I could not run an in-browser encode. The underlying C change was verified on the server side via the native
make wasm_testbuild (compiles clean; a 20 s PCM encode yields a valid TAF with correct OggS pages). If you'd rather regenerate this with your own toolchain to be safe, that's totally reasonable — happy to defer to that.Targeted at
develop.