Skip to content

Added � and ⚠#1175

Open
gjvnq wants to merge 3 commits into
tonsky:masterfrom
gjvnq:master
Open

Added � and ⚠#1175
gjvnq wants to merge 3 commits into
tonsky:masterfrom
gjvnq:master

Conversation

@gjvnq

@gjvnq gjvnq commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@tonsky

tonsky commented Dec 28, 2020

Copy link
Copy Markdown
Owner

Wow, thanks. But

75,971 additions, 73,603 deletions

Not sure how to merge this. Also

- .appVersion = "1348";
+ .appVersion = "3039";
+ .formatVersion = 3;

I haven’t bought the new version yet (not sure if will).

Any way you can isolate just the outlines? Would be happy to merge those

@gjvnq

gjvnq commented Dec 29, 2020 via email

Copy link
Copy Markdown
Contributor Author

@gjvnq

gjvnq commented Dec 29, 2020

Copy link
Copy Markdown
Contributor Author

I redid my work and I hope it can now work on the old version of the app.

@tonsky

tonsky commented Dec 29, 2020

Copy link
Copy Markdown
Owner

Thank you, I merged U+FFFD as a755aab.

About ⚠, I am not sure: I don’t like how it looks. Maybe base it on equilateral triangle?

This is how it looks in your PR:

Screenshot 2020-12-29 at 18 36 57

Screenshot 2020-12-29 at 18 37 02

These are some other characters from the font that look more fira code-like.

Screenshot 2020-12-29 at 18 37 13

Screenshot 2020-12-29 at 18 37 45

Screenshot 2020-12-29 at 18 38 13

I also feel that line width should match stem width.

@tonsky

tonsky commented Dec 29, 2020

Copy link
Copy Markdown
Owner

The actual commit is 415c773 (forgot to update CHANGELOG.md)

@itsMo07

itsMo07 commented Mar 4, 2021

Copy link
Copy Markdown

Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants