Skip to content

PM-3575 - Add new endpoint to fetch salesforce BAs for user#9

Merged
kkartunov merged 3 commits into
developfrom
PM-3575_salesforce-user-ba
Feb 3, 2026
Merged

PM-3575 - Add new endpoint to fetch salesforce BAs for user#9
kkartunov merged 3 commits into
developfrom
PM-3575_salesforce-user-ba

Conversation

@vas3a

@vas3a vas3a commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

https://topcoder.atlassian.net/browse/PM-3575
As discussed - added new endpoint to fetch BAs for a user via the salesforce connected app.

@vas3a
vas3a requested review from jmgasper and kkartunov February 3, 2026 10:54
Comment thread src/billing-accounts/billing-accounts.controller.ts Outdated
Comment thread src/billing-accounts/billing-accounts.service.ts
Comment thread src/billing-accounts/billing-accounts.service.ts Outdated
Comment thread src/common/salesforce.service.ts
Comment thread src/common/salesforce.service.ts
Comment thread src/common/salesforce.service.ts
Comment thread src/common/salesforce.service.ts
Comment thread src/common/salesforce.service.ts
Comment thread src/billing-accounts/billing-accounts.service.ts Fixed

/**
* List billing accounts one or more user IDs have access to (via Salesforce resource object).
* Accepts a single userId (number) or an array of userId strings.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The function documentation states that userId can be a number or an array of strings, but the function signature only accepts a number. Consider updating the documentation or the function signature for consistency.

Comment thread src/billing-accounts/billing-accounts.service.ts
@kkartunov
kkartunov merged commit 848b3bf into develop Feb 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants