Tweaks for compilation output

Author: jmgasper

docs/submission-phase-scoring.md

@@ -101,7 +101,7 @@ Runner task logs are written to CloudWatch using the submission runner log strea
 
 For `PROVISIONAL` and `SYSTEM` scoring, the runner writes progress to the phase review summation metadata through `POST /v6/marathon-match/internal/scoring-progress`. Review API exposes this as `reviewSummation.metadata.testProcess` (`provisional` or `system`), `reviewSummation.metadata.testProgress` (`0` to `1`), and `reviewSummation.metadata.testStatus` (`IN PROGRESS`, `SUCCESS`, or `FAILED`) when metadata is included in the response. In-progress summations keep a neutral placeholder score and must be rendered as unavailable based on `testStatus`; only `FAILED` progress uses the failed-score sentinel. SYSTEM timeout failures also include `reviewSummation.metadata.timed_out = true`.
 
-For generic runner artifacts, only EXAMPLE scoring uploads the member-visible public artifact. Its public `output.txt` starts with the captured compilation output, then includes each testcase ordinal, actual seed, seed score, runtime, runner/tester errors, and submitted-solution stderr, while submitted-solution stdout stays private. Every generic scoring phase uploads private internal artifacts: `reviews.json` includes `compilationOutput`, per-test score details with testcase ordinals and actual seeds, and top-level `testScores`; callback metadata keeps member-visible testcase ordinals only, compile and execution logs are preserved as `compile_log.txt`, `execution-{submissionId}.log`, and optional `error-{submissionId}.log`, and captured submitted-solution output is split into `stdout/{seed}.txt` and `stderr/{seed}.txt` files for each actual seed. PROVISIONAL and SYSTEM scoring do not publish competitor-visible artifacts.
+For generic runner artifacts, only EXAMPLE scoring uploads the member-visible public artifact. Its public `output.txt` includes each testcase ordinal, actual seed, seed score, runtime, runner/tester errors, and submitted-solution stderr, while submitted-solution stdout and compilation diagnostics stay out of that file. The separate `compile_log.txt` file preserves compilation output. Every generic scoring phase uploads private internal artifacts: `reviews.json` includes `compilationOutput`, per-test score details with testcase ordinals and actual seeds, and top-level `testScores`; callback metadata keeps member-visible testcase ordinals only, compile and execution logs are preserved as `compile_log.txt`, `execution-{submissionId}.log`, and optional `error-{submissionId}.log`, and captured submitted-solution output is split into `stdout/{seed}.txt` and `stderr/{seed}.txt` files for each actual seed. PROVISIONAL and SYSTEM scoring do not publish competitor-visible artifacts.
 
 When more than one phase config matches the currently open challenge phases, the handler launches one scorer task per match. This is the supported way to run both `EXAMPLE` and `PROVISIONAL` scoring from the same Submission phase.
 

ecs-runner/README.md

@@ -142,7 +142,7 @@ Once this is saved and the config is active, new scoring launches use the new EC
 
 The runner rejects output once generated public `output.txt` content or a public/private artifact archive would exceed `MM_RUNNER_MAX_OUTPUT_BYTES`. The default is `10000000` bytes. The trusted parent runner passes the resolved limit into the isolated tester child, so generated generic-runner output and uploaded artifact zips use the same cap.
 
-Generic runner member-visible artifacts are uploaded only for EXAMPLE scoring. Their public `output.txt` starts with the captured compilation output, then shows testcase ordinal, actual seed, seed score, runtime, runner/tester errors, and submitted-solution stderr, while intentionally omitting submitted-solution stdout. Every generic scoring phase uploads private internal artifacts in the `*-internal` zip: `reviews.json` carries `compilationOutput`, per-test `metadata.testScores`, and top-level `testScores` with testcase ordinals and actual seeds, `compile_log.txt` and `execution-{submissionId}.log` preserve runner diagnostics, `error-{submissionId}.log` is included when present, and `stdout/{seed}.txt` plus `stderr/{seed}.txt` carry captured submitted-solution output for each actual seed. PROVISIONAL and SYSTEM scoring do not publish competitor-visible artifacts.
+Generic runner member-visible artifacts are uploaded only for EXAMPLE scoring. Their public `output.txt` shows testcase ordinal, actual seed, seed score, runtime, runner/tester errors, and submitted-solution stderr, while intentionally omitting submitted-solution stdout and compilation diagnostics. The separate `compile_log.txt` file preserves compilation output. Every generic scoring phase uploads private internal artifacts in the `*-internal` zip: `reviews.json` carries `compilationOutput`, per-test `metadata.testScores`, and top-level `testScores` with testcase ordinals and actual seeds, `compile_log.txt` and `execution-{submissionId}.log` preserve runner diagnostics, `error-{submissionId}.log` is included when present, and `stdout/{seed}.txt` plus `stderr/{seed}.txt` carry captured submitted-solution output for each actual seed. PROVISIONAL and SYSTEM scoring do not publish competitor-visible artifacts.
 
 ## Local smoke test
 

ecs-runner/src/main/java/com/topcoder/runner/EcsRunnerMain.java

@@ -4651,12 +4651,7 @@ private static TesterExecutionResult runGenericMarathonTester(
             );
             String compilationOutput = readCompilationOutput(compileLogPath);
             StringBuilder outputText = new StringBuilder();
-            long outputBytes = appendLimitedOutput(
-                outputText,
-                buildMemberVisibleCompilationOutput(compilationOutput),
-                0L,
-                "artifacts/public/output.txt"
-            );
+            long outputBytes = 0L;
             grantScorerReadExecuteAccess(compileWorkDir);
 
             MarathonController controller = new MarathonController();
@@ -4780,7 +4775,7 @@ private static TesterExecutionResult runGenericMarathonTester(
                 new ArrayList<Map<String, Object>>()
             );
         } catch (Exception error) {
-            writePreResultMemberOutput(outputPath, compileLogPath, error);
+            writePreResultMemberOutput(outputPath, error);
             throw error;
         } finally {
             if (!cleanupDeferred) {
@@ -4790,7 +4785,7 @@ private static TesterExecutionResult runGenericMarathonTester(
     }
 
     /**
-     * Reads the compiler log that should be embedded in member-visible and private outputs.
+     * Reads the compiler log that should be retained in metadata and private outputs.
      *
      * @param compileLogPath Public compile log written by compiler commands.
      * @return Compiler output text, or a short no-output marker when no compiler command ran.
@@ -4811,37 +4806,15 @@ private static String readCompilationOutput(Path compileLogPath) throws IOExcept
         return compilationOutput;
     }
 
-    /**
-     * Builds the public {@code output.txt} compilation section shown before test cases.
-     *
-     * @param compilationOutput Compiler diagnostics captured for the submission.
-     * @return Member-visible compilation text block ending with a blank line.
-     */
-    private static String buildMemberVisibleCompilationOutput(
-        String compilationOutput
-    ) {
-        StringBuilder outputText = new StringBuilder();
-        outputText.append("Compilation Output:\n");
-        if (compilationOutput == null || compilationOutput.trim().isEmpty()) {
-            outputText.append("No compilation output was produced.");
-        } else {
-            outputText.append(compilationOutput.trim());
-        }
-        outputText.append("\n\n");
-        return outputText.toString();
-    }
-
     /**
      * Writes a partial member-visible output file when the generic runner fails
      * before normal score output can be finalized.
      *
      * @param outputPath Public {@code output.txt} artifact path.
-     * @param compileLogPath Public compile log path to embed.
      * @param error Failure that prevented normal output generation.
      */
     private static void writePreResultMemberOutput(
         Path outputPath,
-        Path compileLogPath,
         Throwable error
     ) {
         if (outputPath == null || isNonSymlinkRegularFile(outputPath)) {
@@ -4850,16 +4823,10 @@ private static void writePreResultMemberOutput(
 
         try {
             StringBuilder outputText = new StringBuilder();
-            long outputBytes = appendLimitedOutput(
-                outputText,
-                buildMemberVisibleCompilationOutput(readCompilationOutput(compileLogPath)),
-                0L,
-                "artifacts/public/output.txt"
-            );
             appendLimitedOutput(
                 outputText,
                 "Runner Error:\n" + safeLogValue(error == null ? null : error.getMessage()) + "\n",
-                outputBytes,
+                0L,
                 "artifacts/public/output.txt"
             );
 

ecs-runner/src/test/java/com/topcoder/runner/EcsRunnerMainTest.java

@@ -130,27 +130,7 @@ public void buildMemberVisibleTestOutputShowsSeedAndScoreButHidesStdout()
     }
 
     @Test
-    public void buildMemberVisibleCompilationOutputShowsCompilerDiagnostics()
-        throws Exception {
-        Method method = EcsRunnerMain.class.getDeclaredMethod(
-            "buildMemberVisibleCompilationOutput",
-            String.class
-        );
-        method.setAccessible(true);
-
-        String output = (String) method.invoke(
-            null,
-            "$ javac Solution.java\nwarning: unchecked conversion\nExit code: 0\n"
-        );
-
-        assertTrue(output.startsWith("Compilation Output:\n"));
-        assertTrue(output.contains("$ javac Solution.java"));
-        assertTrue(output.contains("warning: unchecked conversion"));
-        assertTrue(output.endsWith("\n\n"));
-    }
-
-    @Test
-    public void writePreResultMemberOutputIncludesCompilationOutputOnFailure()
+    public void writePreResultMemberOutputLeavesCompilationInCompileLogOnFailure()
         throws Exception {
         Path artifactsDir = createArtifactsDir();
         Path outputPath = artifactsDir.resolve("public").resolve("output.txt");
@@ -165,22 +145,25 @@ public void writePreResultMemberOutputIncludesCompilationOutputOnFailure()
         Method method = EcsRunnerMain.class.getDeclaredMethod(
             "writePreResultMemberOutput",
             Path.class,
-            Path.class,
             Throwable.class
         );
         method.setAccessible(true);
         method.invoke(
             null,
             outputPath,
-            compileLogPath,
             new RuntimeException("C++ compilation failed.")
         );
 
         String output = new String(Files.readAllBytes(outputPath), StandardCharsets.UTF_8);
-        assertTrue(output.contains("Compilation Output:"));
-        assertTrue(output.contains("compile failed"));
+        String compileLog = new String(
+            Files.readAllBytes(compileLogPath),
+            StandardCharsets.UTF_8
+        );
+        assertFalse(output.contains("Compilation Output:"));
+        assertFalse(output.contains("compile failed"));
         assertTrue(output.contains("Runner Error:"));
         assertTrue(output.contains("C++ compilation failed."));
+        assertTrue(compileLog.contains("compile failed"));
     }
 
     @Test