Ommit release_date from non-engagement payment

Author: vas3a

src/api/winnings/winnings.service.spec.ts

@@ -318,7 +318,10 @@ describe('WinningsService', () => {
     const persistedPayment =
       tx.winnings.create.mock.calls[0][0].data.payment.create[0];
 
-    expect(persistedPayment.release_date).toBeNull();
+    expect(persistedPayment.release_date).toBeUndefined();
+    expect(
+      Object.prototype.hasOwnProperty.call(persistedPayment, 'release_date'),
+    ).toBe(false);
   });
 
   it('rejects engagement payment details that do not match the assignment billing account', async () => {

src/api/winnings/winnings.service.ts

@@ -1289,10 +1289,10 @@ export class WinningsService {
           tx,
         );
 
+      const engagementReleaseDate = isEngagementPayment
+        ? this.buildEngagementReleaseDate()
+        : undefined;
       for (const [detailIndex, detail] of (body.details || []).entries()) {
-        const engagementReleaseDate = isEngagementPayment
-          ? this.buildEngagementReleaseDate()
-          : undefined;
         const challengeFee = engagementConsumePlan
           ? this.calculateEngagementChallengeFee(
               Number(detail.totalAmount),
@@ -1315,7 +1315,9 @@ export class WinningsService {
             ? Prisma.Decimal(engagementConsumePlan.challengeMarkup)
             : null,
           challenge_fee: Prisma.Decimal(challengeFee),
-          release_date: engagementReleaseDate ?? null,
+          ...(engagementReleaseDate !== undefined
+            ? { release_date: engagementReleaseDate }
+            : {}),
         };
 
         paymentModel.net_amount = Prisma.Decimal(detail.grossAmount);