Fix for engagement payments not displaying in wallet

Author: jmgasper

prisma/schema.prisma

@@ -330,6 +330,5 @@ enum winnings_category {
 enum winnings_type {
   PAYMENT
   REWARD
-  ENGAGEMENT
   POINTS
 }

src/api/repository/winnings.repo.ts

@@ -63,6 +63,12 @@ export class WinningsRepository {
     externalIds?: string[],
     date?: DateFilterType,
   ): Prisma.winningsFindManyArgs['where'] {
+    const typeFilter = type
+      ? {
+          equals: type as winnings_type,
+        }
+      : undefined;
+
     return {
       winner_id: winnerIds
         ? {
@@ -79,11 +85,7 @@ export class WinningsRepository {
             equals: category as winnings_category,
           }
         : undefined,
-      type: type
-        ? {
-            equals: type as winnings_type,
-          }
-        : undefined,
+      type: typeFilter,
       payment: status
         ? {
             some: {

src/api/winnings/winnings.service.ts

@@ -212,9 +212,26 @@ export class WinningsService {
         return result;
       }
 
+      const isEngagementPayment =
+        body.category === WinningsCategory.ENGAGEMENT_PAYMENT;
+      const resolvedType = isEngagementPayment
+        ? WinningsType.PAYMENT
+        : body.type;
+
+      if (isEngagementPayment && body.type !== WinningsType.PAYMENT) {
+        this.logger.warn(
+          'Engagement payment type overridden to PAYMENT.',
+          {
+            winnerId: body.winnerId,
+            externalId: body.externalId,
+            requestedType: body.type,
+          },
+        );
+      }
+
       const winningModel = {
         winner_id: body.winnerId,
-        type: winnings_type[body.type],
+        type: winnings_type[resolvedType],
         origin_id: originId,
         category: winnings_category[body.category],
         title: body.title,

src/dto/winning.dto.ts

@@ -20,7 +20,6 @@ import {
 
 export enum WinningsType {
   PAYMENT = 'PAYMENT',
-  ENGAGEMENT = 'ENGAGEMENT',
   POINTS = 'POINTS',
 }