Fixes for calculations to help with PM-5507

Author: jmgasper

src/api/repository/winnings.repo.spec.ts

@@ -29,6 +29,7 @@ describe('WinningsRepository', () => {
     findManyMock = jest.fn().mockResolvedValue([]);
 
     const prismaMock = {
+      $queryRaw: jest.fn().mockResolvedValue([]),
       winnings: {
         findMany: findManyMock,
       },
@@ -162,4 +163,52 @@ describe('WinningsRepository', () => {
     });
     expect(findManyArgs.where.winner_id).toBeUndefined();
   });
+
+  it('returns persisted challenge fee and markup for external-id payment history', async () => {
+    const createdAt = new Date('2026-06-15T13:28:18.662Z');
+
+    findManyMock.mockResolvedValueOnce([
+      {
+        attributes: {},
+        category: 'ENGAGEMENT_PAYMENT',
+        created_at: createdAt,
+        description: 'Wipro - UHG - Power BI resources',
+        external_id: 'assignment-1',
+        origin: {
+          origin_name: 'Topcoder',
+        },
+        payment: [
+          {
+            billing_account: '80004405',
+            challenge_fee: 386.94,
+            challenge_markup: 0.71,
+            currency: 'USD',
+            date_paid: createdAt,
+            gross_amount: 544.99,
+            installment_number: 1,
+            net_amount: 0,
+            payment_id: '8fbb836d-3d6b-4e19-a4cc-871e0e1bc12d',
+            payment_status: 'PAID',
+            release_date: createdAt,
+            total_amount: 544.99,
+            updated_at: createdAt,
+          },
+        ],
+        title: 'Wipro - UHG - Power BI resources',
+        type: 'PAYMENT',
+        updated_at: createdAt,
+        winner_id: '500013447',
+        winning_id: 'winning-1',
+      },
+    ]);
+
+    const result = await winningsRepo.getWinningsByExternalId('assignment-1');
+
+    expect(result.data?.[0].details[0]).toMatchObject({
+      billingAccount: '80004405',
+      challengeFee: 386.94,
+      challengeMarkup: 0.71,
+      totalAmount: 544.99,
+    });
+  });
 });

src/api/repository/winnings.repo.ts

@@ -406,6 +406,16 @@ export class WinningsRepository {
               releaseDate: paymentItem.release_date as Date,
               category: item.category as string,
               billingAccount: paymentItem.billing_account,
+              challengeFee:
+                paymentItem.challenge_fee === null ||
+                paymentItem.challenge_fee === undefined
+                  ? undefined
+                  : Number(paymentItem.challenge_fee),
+              challengeMarkup:
+                paymentItem.challenge_markup === null ||
+                paymentItem.challenge_markup === undefined
+                  ? undefined
+                  : Number(paymentItem.challenge_markup),
             })),
             createdAt: item.created_at as Date,
             updatedAt: (item.payment?.[0].date_paid ??
@@ -507,6 +517,16 @@ export class WinningsRepository {
             releaseDate: paymentItem.release_date as Date,
             category: item.category as string,
             billingAccount: paymentItem.billing_account,
+            challengeFee:
+              paymentItem.challenge_fee === null ||
+              paymentItem.challenge_fee === undefined
+                ? undefined
+                : Number(paymentItem.challenge_fee),
+            challengeMarkup:
+              paymentItem.challenge_markup === null ||
+              paymentItem.challenge_markup === undefined
+                ? undefined
+                : Number(paymentItem.challenge_markup),
           })),
           createdAt: item.created_at as Date,
           updatedAt: (item.payment?.[0].date_paid ??

src/dto/payment.dto.ts

@@ -34,6 +34,22 @@ export class PaymentDetailDto {
   releaseDate: Date;
   category: string;
   billingAccount: string;
+
+  @ApiProperty({
+    description:
+      'Persisted billing-account challenge fee for this payment detail. Engagement payments use this value to reconcile finance payment splits with billing-account consumed rows.',
+    example: 386.94,
+    required: false,
+  })
+  challengeFee?: number;
+
+  @ApiProperty({
+    description:
+      'Persisted billing-account markup used when the challenge fee was calculated.',
+    example: 0.71,
+    required: false,
+  })
+  challengeMarkup?: number;
 }
 
 export class PaymentCreateRequestDto {