Skip to content

Prod release - BA visibility tweaks May 2026#181

Merged
jmgasper merged 3 commits into
masterfrom
dev
May 12, 2026
Merged

Prod release - BA visibility tweaks May 2026#181
jmgasper merged 3 commits into
masterfrom
dev

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

jmgasper added 3 commits May 7, 2026 22:43
What was broken
Wallet-admin payment amount adjustments did not trigger billing-account budget reconciliation, so BA summary rows stayed at the prior consumed amount.

Root cause
Finance only recalculated BA challenge and engagement ledger rows when wallet admin cancelled a payment. Amount-only edits updated finance payment rows but skipped the BA sync path. Engagement edits also left the persisted challenge fee based on the old amount.

What was changed
Reuse BA sync target discovery for wallet-admin amount edits.
Recalculate engagement challenge_fee from the persisted markup during amount updates before syncing consumed rows.
Preserve computed task payment status in challenge-generated payments so lint and existing status behavior stay aligned.

Any added/updated tests
Added admin service coverage for challenge and engagement amount adjustments syncing BA rows.
Ran the full Jest suite, lint, and build.
PM-4972: Sync BA summary after wallet amount edits
@jmgasper
jmgasper merged commit 993080e into master May 12, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant