PM-4669 - support for payment cycles engagement payments#182
Merged
Conversation
kkartunov
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of payment details for assignments by introducing support for a
paymentCyclefield and astandardHoursPerDayfield throughout the admin service and related DTOs. These changes ensure that assignment payment cycles and daily standard hours are consistently managed and exposed via the API, improving data accuracy and flexibility.Payment Details Enhancements:
Added a new
PaymentCycletype ('WEEKLY' | 'FORTNIGHTLY' | 'MONTHLY') and integrated it into thePaymentEngagementDetailsDtoand related logic, allowing assignments to specify their payment cycle.Introduced a
standardHoursPerDayfield toPaymentEngagementDetailsDtoand related interfaces, with logic to derive its value fromstandardHoursPerWeekwhen not explicitly provided.Service and Interface Updates:
Updated
AdminServiceto handle the newpaymentCycleandstandardHoursPerDayfields when transforming assignment and engagement data, ensuring default values and correct type casting.Extended
TopcoderAssignmentContextandTopcoderEngagementAssignmentinterfaces to include the new fields, supporting end-to-end data flow.