PM-5049 - make release window configurable for engagement payments#183
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an environment-configurable release window for engagement payments and applies it when creating nested payment records for engagement winnings.
Changes:
- Introduces
ENGAGEMENT_PAYMENT_RELEASE_WINDOW_DAYSinConfigEnvwith validation/defaulting. - Updates
WinningsService#createWinningWithPaymentsto setpayment.release_datefor engagement payments. - Adds unit tests covering engagement vs non-engagement
release_datebehavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/config/config.env.ts | Adds and validates ENGAGEMENT_PAYMENT_RELEASE_WINDOW_DAYS env config used by the service. |
| src/api/winnings/winnings.service.ts | Computes an engagement-specific release_date and includes it in nested payment creation. |
| src/api/winnings/winnings.service.spec.ts | Adds tests asserting engagement payments get a delayed release_date and non-engagement payments do not. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a configurable release window for engagement payments, ensuring that such payments have a specific delay before being released, as set in the environment configuration.
ENGAGEMENT_PAYMENT_RELEASE_WINDOW_DAYSto the environment configuration and validated it inConfigEnvto allow customization of the release window for engagement payments.WinningsServiceto calculate and set therelease_datefor engagement payments using the configured window, while keeping the release datenullfor other payment types.