fix: postinstall should ignore adding hooks if SKIP_INSTALL_SIMPLE_GI…#128
Merged
Conversation
JounQin
requested changes
Jun 13, 2025
OlofFredriksson
force-pushed
the
master
branch
2 times, most recently
from
5c68354 to
1718d1a
Compare
🦋 Changeset detectedLatest commit: ecc2d0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JounQin
reviewed
Jun 14, 2025
…T_HOOKS is defined
JounQin
reviewed
Jun 15, 2025
JounQin
approved these changes
Jun 16, 2025
JounQin
left a comment
JounQin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Thanks for your contribution!
toplenboren
approved these changes
Jun 16, 2025
toplenboren
left a comment
toplenboren
left a comment
Owner
There was a problem hiding this comment.
LGTM! Thanks for the contribution
This was referenced Jul 31, 2025
1 task
1 task
This was referenced Aug 22, 2025
1 task
1 task
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if feature or bug (or me doing something wrong..) but shouldn't
postinstall.jsbehave likecli.js? i.e not adding any hooks ifSKIP_INSTALL_SIMPLE_GIT_HOOKSis defined?