chore: remove some unnecessary ignore files#135
Conversation
|
WalkthroughUpdated .eslintignore to stop ignoring node_modules and package-lock.json. The file now ignores only .idea, .git, and package.json. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey, thanks for the PR! Just merged it |
This pr aims to remove some unnecessary eslint ignore files.
The first file is
node_modules. It is included in eslint internally.The second file is
package-lock.json. The recommended node package manager of this repo isyarn. So I think it is not necessary to ignore this file specially.@JounQin please review it when you have time. If you have any suggestions, please tell me. Thanks!
Summary by CodeRabbit