Skip to content

Commit a89228a

Browse files
address greptile review feedback (greploop iteration 1)
- voice_caller.py: drop unused 'threading' import; make LXST/Sideband checkout paths overridable via LXST_SRC/SIDEBAND_SRC (SIDEBAND_SRC matches conftest) with a clear error if missing, instead of hardcoded ~/repos paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 4e2af13 commit a89228a

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

Tests/interop/voice_caller.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,18 @@
1212
PYTHONPATH unneeded — paths injected below.
1313
python3 voice_caller.py <columba_identity_hex> [ring_seconds]
1414
"""
15-
import sys, os, time, threading
16-
17-
sys.path.insert(0, os.path.expanduser("~/repos/LXST"))
18-
sys.path.insert(0, os.path.expanduser("~/repos/Sideband"))
15+
import sys, os, time
16+
17+
# LXST + Sideband are sibling checkouts; override with LXST_SRC / SIDEBAND_SRC
18+
# (SIDEBAND_SRC matches the interop conftest). Default to ~/repos/<name>.
19+
for _name, _env, _default in (
20+
("LXST", "LXST_SRC", "~/repos/LXST"),
21+
("Sideband", "SIDEBAND_SRC", "~/repos/Sideband"),
22+
):
23+
_path = os.environ.get(_env, os.path.expanduser(_default))
24+
if not os.path.isdir(_path):
25+
sys.exit(f"{_name} checkout not found at {_path} — set {_env} to its path.")
26+
sys.path.insert(0, _path)
1927

2028
import RNS # noqa: E402
2129
from sbapp.sideband.voice import ReticulumTelephone # noqa: E402

0 commit comments

Comments
 (0)