fix(MessageBubble): clamp future-dated timestamps to now (supersedes #66)

[torlando-tech]

Re-applies the iOS half of #60 fresh on current main. Supersedes #66, which is 78 commits stale (predates the dual-backend refactor) and conflicts on both MessageBubble.swift and project.pbxproj.

Problem (still live on main)

Message.formattedTime is still the unclamped

Self.relativeFormatter.localizedString(for: timestamp, relativeTo: Date())

so a future-dated wire timestamp (peer clock skew, or our own past clock) renders "in 5 min" on a message that has already arrived.

Fix

• MessageBubble.swift: clamp the displayed relative time to min(timestamp, now) → renders "Just now" instead. The absolute-time formatter in MessageDetailView is intentionally left alone (raw protocol metadata).
• MessageFormattedTimeTests.swift: future-dated → formatter's "now" string; past-dated → relative-past (regression guard). Wired into ColumbaAppTests.

Verified

build-for-testing succeeds and both tests pass on the simulator (Executed 2 tests, 0 failures).

Refs #60 (display half only; the out-of-order-messages half was a separate LXMF-swift ordering change).

[greptile-apps]

Greptile Summary

This PR clamps future-dated message timestamps to the current time before passing them to RelativeDateTimeFormatter, preventing "in 5 min" from appearing on already-arrived messages. It also wires in two new unit tests for the formatting path.

• MessageBubble.swift: formattedTime now captures Date() once, computes display = min(timestamp, now), and passes both to the formatter — so a wire timestamp ahead of local time renders "Just now" rather than a future-relative string.
• MessageFormattedTimeTests.swift: Adds a future-clamping assertion and a past-relative regression guard (anchored at 2 hr to avoid the 60-min formatter boundary noted in the previous review thread).

Confidence Score: 5/5

Safe to merge — the change is a small, self-contained clamp with no side effects on the absolute-time formatter or any other display path.

The clamping logic captures now once and feeds both arguments to the formatter correctly, so future-dated timestamps always resolve to "Just now" and past timestamps are unaffected. Tests cover both branches with offsets well clear of formatter rounding boundaries.

No files require special attention.

Important Files Changed

Filename	Overview
Sources/ColumbaApp/Views/Messaging/MessageBubble.swift	Clamping fix is minimal and correct: captures now once, uses min(timestamp, now) as the display date, and passes both to the formatter so relative output is always in the past or "Just now".
Tests/ColumbaAppTests/MessageFormattedTimeTests.swift	Two tests cover the future-clamping and past-relative paths; offsets chosen (600 s future, 7200 s past) are safely away from formatter rounding boundaries.
Columba.xcodeproj/project.pbxproj	Standard Xcode project entries for the new test file; PBXFileReference and PBXBuildFile UUIDs are unique and both target sections are updated correctly.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["formattedTime called"] --> B["let now = Date()"]
    B --> C{"timestamp > now?"}
    C -- "Yes (future-dated wire ts)" --> D["display = now"]
    C -- "No (past or present)" --> E["display = timestamp"]
    D --> F["localizedString(for: now, relativeTo: now)\n→ 'Just now'"]
    E --> G["localizedString(for: timestamp, relativeTo: now)\n→ '2 hr. ago', etc."]

Loading

_{Reviews (3): Last reviewed commit: "address greptile review feedback (greplo..." | Re-trigger Greptile}

[torlando-tech]

@greptile review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!