Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
plugins {
id("com.android.application") version "9.1.0" apply false
id("com.android.library") version "9.1.0" apply false
id("org.jetbrains.kotlin.plugin.compose") version "2.3.21" apply false
id("org.jetbrains.kotlin.plugin.compose") version "2.4.0" apply false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Compose compiler stability default changed in 2.4.0

The Kotlin 2.4.0 changelog (commit ef14611) changes the default stability of non-final classes from Stable to Unknown. Any non-final class used as a @Composable parameter that was previously treated as stable will now be treated as unstable, potentially triggering additional recompositions at runtime. Review Composable call sites that accept non-final types (e.g., interfaces, open classes) and add explicit @Stable / @Immutable annotations or ensure classes are data class / final where stability is required.

Prompt To Fix With AI
This is a comment left during a code review.
Path: build.gradle.kts
Line: 5

Comment:
**Compose compiler stability default changed in 2.4.0**

The Kotlin 2.4.0 changelog (commit `ef14611`) changes the default stability of non-final classes from `Stable` to `Unknown`. Any non-final class used as a `@Composable` parameter that was previously treated as stable will now be treated as unstable, potentially triggering additional recompositions at runtime. Review Composable call sites that accept non-final types (e.g., interfaces, open classes) and add explicit `@Stable` / `@Immutable` annotations or ensure classes are `data class` / `final` where stability is required.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

id("com.google.dagger.hilt.android") version "2.59.2" apply false
id("com.google.devtools.ksp") version "2.3.6" apply false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 KSP version incompatible with Kotlin 2.4.0

com.google.devtools.ksp is pinned at 2.3.6, which targets an earlier Kotlin release. The official Kotlin documentation pairs Kotlin 2.4.0 with KSP 2.3.9. Running KSP 2.3.6 against the 2.4.0 compiler plugins will cause a version-mismatch error at build time (KSP validates the Kotlin compiler version it was built against). This PR should also bump KSP to 2.3.9.

Prompt To Fix With AI
This is a comment left during a code review.
Path: build.gradle.kts
Line: 7

Comment:
**KSP version incompatible with Kotlin 2.4.0**

`com.google.devtools.ksp` is pinned at `2.3.6`, which targets an earlier Kotlin release. The official Kotlin documentation pairs Kotlin 2.4.0 with KSP `2.3.9`. Running KSP 2.3.6 against the 2.4.0 compiler plugins will cause a version-mismatch error at build time (KSP validates the Kotlin compiler version it was built against). This PR should also bump KSP to `2.3.9`.

How can I resolve this? If you propose a fix, please make it concise.

id("org.jetbrains.kotlin.plugin.serialization") version "2.3.21" apply false
id("org.jetbrains.kotlin.plugin.serialization") version "2.4.0" apply false
id("io.sentry.android.gradle") version "6.1.0" apply false
// Chaquopy — applied ONLY by :rns-backend-py (module-level, never at :app level)
// so the kotlinBackend flavor's classpath is never polluted with the Python
Expand Down
Loading