Move Translations#889
Conversation
Greptile SummaryThis PR extracts all hardcoded strings from the onboarding and welcome screens into Confidence Score: 5/5Safe to merge; only a P2 style nit on two camelCase key names remains. All findings are P2 (naming convention only). No logic, correctness, or runtime issues were found. The string extraction and Russian translation are functionally correct. No files require special attention beyond the optional nextAction to next_action rename. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([App Launch]) --> B[WelcomeScreen]
B -->|Get Started| C[OnboardingPagerScreen]
B -->|Restore| Z([Restore Flow])
C --> D[WelcomePage]
D -->|Continue| E[IdentityPage]
E -->|Continue| F[ConnectivityPage]
F -->|Continue| G[PermissionsPage]
G -->|Continue| H([Setup Complete])
D -->|Skip| H
E -->|Back| D
F -->|Back| E
G -->|Back| F
subgraph strings [String Resources]
EN[values/strings.xml]
RU[values-ru/strings.xml]
end
D & E & F & G & B & C -.->|stringResource| strings
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
app/src/main/res/values/strings.xml:47
Two resource key names use camelCase (`nextAction`, `unrestricted_battery_secondDescription`) while every other key in this file uses `snake_case`. Android's resource naming convention is `snake_case` throughout, and both entries break that consistency. The same pattern appears in `values-ru/strings.xml` (lines 34 and 50). Renaming them to `next_action` and `unrestricted_battery_second_description` also requires updating all Kotlin `R.string.*` references in `ConnectivityPage.kt`, `IdentityPage.kt`, `PermissionsPage.kt`, and `WelcomeScreen.kt`.
```suggestion
<string name="next_action">Continue</string>
```
Reviews (6): Last reviewed commit: "Fix typos in Russian strings.xml" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@torlando-tech, I've fixed a few minor translation errors and it's all ready now. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@mrbober42-lgtm several unit tests failed. for example: |
torlando-tech
left a comment
There was a problem hiding this comment.
Please look through the unit test failures and find why some of them are failing, pay special attention to strings not matching
Many translations from the start menu have been moved to the strings.xml file.
(I also added a Russian translation)