Fix constructables sending one too many packet when being destroyed (SubnauticaNitrox#2503)

Author: dartasen

NitroxClient/Helpers/ThrottledPacketSender.cs

@@ -47,8 +47,11 @@ public bool SendThrottled<T>(T packet, Func<T, object> dedupeMethod, float throt
                 return true;
             }
 
-            throttledPackets.Add(dedupeKey, new ThrottledPacket(packet, throttleTime));
+            throttledPacket = new(packet, throttleTime);
+            throttledPackets.Add(dedupeKey, throttledPacket);
             packetSender.Send(packet);
+            // It's very important to set WasSend to true, otherwise the packet will be sent again in Update()
+            throttledPacket.WasSend = true;
             return true;
         }
 

NitroxPatcher/Patches/Dynamic/Constructable_Construct_Patch.cs

@@ -103,6 +103,12 @@ public static void ConstructionAmountModified(Constructable constructable, bool
         // update as a normal module
         Resolve<ThrottledPacketSender>().SendThrottled(new ModifyConstructedAmount(entityId, amount),
             (packet) => { return packet.GhostId; }, 0.1f);
+
+        // If we're done with that ghost we can remove the throttled packets
+        if (amount == 0)
+        {
+            Resolve<ThrottledPacketSender>().RemovePendingPackets(entityId);
+        }
     }
 
     public static IEnumerator BroadcastObjectBuilt(ConstructableBase constructableBase, NitroxId entityId)