Skip to content

Commit 303c864

Browse files
committed
docs: mark all proposals complete in standardize-command-view-folder-structure plan
Update refactor plan to reflect completed status: - Mark all 3 proposals as Completed with commit hashes - Update Progress Tracking: 3/3 complete, 0 not started - Mark all implementation checklist items as done [x] - Update phase summaries to 100% completion - Update Last Updated date and Status to Completed Commits: - Proposal #1: 8e3f8a4 (move run views/ subfolder) - Proposal #2: ff0c6d7 (extract run DTO to view_data/) - Proposal #3: 3d63edc (add view_data/ to list and show)
1 parent 3d63edc commit 303c864

1 file changed

Lines changed: 48 additions & 48 deletions

File tree

docs/refactors/plans/standardize-command-view-folder-structure.md

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ harder to review (logic changes + file moves mixed). The correct order is:
6161
**Total Active Proposals**: 3
6262
**Total Postponed**: 0
6363
**Total Discarded**: 0
64-
**Completed**: 0
64+
**Completed**: 3
6565
**In Progress**: 0
66-
**Not Started**: 3
66+
**Not Started**: 0
6767

6868
### Phase Summary
6969

70-
- **Phase 0 - Fix `run` module layout (High Impact, Low Effort)**: ⏳ 0/2 completed (0%)
71-
- **Phase 1 - Fix `list` and `show` module layout (Medium Impact, Low Effort)**: ⏳ 0/1 completed (0%)
70+
- **Phase 0 - Fix `run` module layout (High Impact, Low Effort)**: ✅ 2/2 completed (100%)
71+
- **Phase 1 - Fix `list` and `show` module layout (Medium Impact, Low Effort)**: ✅ 1/1 completed (100%)
7272

7373
### Discarded Proposals
7474

@@ -134,13 +134,13 @@ For `list` and `show`, this means creating thin wrapper or re-export modules in
134134

135135
### Proposal #1: Move `run` View Files Into `views/` Subfolder
136136

137-
**Status**: ⏳ Not Started
137+
**Status**: ✅ Completed
138138
**Impact**: 🟢🟢🟢 High
139139
**Effort**: 🔵 Low
140140
**Priority**: P0
141141
**Depends On**: None
142-
**Completed**: -
143-
**Commit**: -
142+
**Completed**: 2026-02-28
143+
**Commit**: `8e3f8a41`
144144

145145
#### Problem
146146

@@ -193,13 +193,13 @@ All public exports from `run/mod.rs` remain the same — callers are unaffected.
193193

194194
#### Implementation Checklist
195195

196-
- [ ] Create directory `src/presentation/cli/views/commands/run/views/`
197-
- [ ] Move `run/json_view.rs` to `run/views/json_view.rs`
198-
- [ ] Move `run/text_view.rs` to `run/views/text_view.rs`
199-
- [ ] Create `run/views/mod.rs` exporting `JsonView` and `TextView`
200-
- [ ] Update `run/mod.rs` to use `mod views` and re-export through it
201-
- [ ] Verify all tests pass
202-
- [ ] Run `cargo run --bin linter all` and fix issues
196+
- [x] Create directory `src/presentation/cli/views/commands/run/views/`
197+
- [x] Move `run/json_view.rs` to `run/views/json_view.rs`
198+
- [x] Move `run/text_view.rs` to `run/views/text_view.rs`
199+
- [x] Create `run/views/mod.rs` exporting `JsonView` and `TextView`
200+
- [x] Update `run/mod.rs` to use `mod views` and re-export through it
201+
- [x] Verify all tests pass
202+
- [x] Run `cargo run --bin linter all` and fix issues
203203

204204
#### Testing Strategy
205205

@@ -210,13 +210,13 @@ E2E tests must pass unchanged.
210210

211211
### Proposal #2: Extract `run` Inline DTO to `view_data/`
212212

213-
**Status**: ⏳ Not Started
213+
**Status**: ✅ Completed
214214
**Impact**: 🟢🟢 Medium
215215
**Effort**: 🔵 Low
216216
**Priority**: P0
217217
**Depends On**: Proposal #1
218-
**Completed**: -
219-
**Commit**: -
218+
**Completed**: 2026-02-28
219+
**Commit**: `ff0c6d7b`
220220

221221
#### Problem
222222

@@ -279,14 +279,14 @@ in other commands (e.g., `ConfigureDetailsData`, `DestroyDetailsData`).
279279

280280
#### Implementation Checklist
281281

282-
- [ ] Create `src/presentation/cli/views/commands/run/view_data/run_details.rs` with `RunDetailsData`
283-
- [ ] Create `src/presentation/cli/views/commands/run/view_data/mod.rs`
284-
- [ ] Update `run/mod.rs` to declare `pub mod view_data`
285-
- [ ] Update `run/views/json_view.rs` to use `RunDetailsData` from `super::super::view_data`
282+
- [x] Create `src/presentation/cli/views/commands/run/view_data/run_details.rs` with `RunDetailsData`
283+
- [x] Create `src/presentation/cli/views/commands/run/view_data/mod.rs`
284+
- [x] Update `run/mod.rs` to declare `pub mod view_data`
285+
- [x] Update `run/views/json_view.rs` to use `RunDetailsData` from `super::super::view_data`
286286
(or the crate-level path) and remove the inline struct
287-
- [ ] Update all call sites constructing the old inline struct to construct `RunDetailsData`
288-
- [ ] Verify all tests pass
289-
- [ ] Run `cargo run --bin linter all` and fix issues
287+
- [x] Update all call sites constructing the old inline struct to construct `RunDetailsData`
288+
- [x] Verify all tests pass
289+
- [x] Run `cargo run --bin linter all` and fix issues
290290

291291
#### Testing Strategy
292292

@@ -299,13 +299,13 @@ old struct. Observable JSON output is unaffected (field names do not change).
299299

300300
### Proposal #3: Add `view_data/` to `list` and `show`
301301

302-
**Status**: ⏳ Not Started
302+
**Status**: ✅ Completed
303303
**Impact**: 🟢🟢 Medium
304304
**Effort**: 🔵 Low
305305
**Priority**: P1
306306
**Depends On**: None (can be parallel with Phase 0)
307-
**Completed**: -
308-
**Commit**: -
307+
**Completed**: 2026-02-28
308+
**Commit**: `3d63edc6`
309309

310310
#### Problem
311311

@@ -379,17 +379,17 @@ file in the command.
379379

380380
#### Implementation Checklist
381381

382-
- [ ] Create `src/presentation/cli/views/commands/list/view_data/list_details.rs`
383-
- [ ] Create `src/presentation/cli/views/commands/list/view_data/mod.rs`
384-
- [ ] Update `list/mod.rs` to declare `pub mod view_data`
385-
- [ ] Update imports in `list/views/json_view.rs` and `list/views/text_view.rs`
386-
- [ ] Create `src/presentation/cli/views/commands/show/view_data/show_details.rs`
387-
- [ ] Create `src/presentation/cli/views/commands/show/view_data/mod.rs`
388-
- [ ] Update `show/mod.rs` to declare `pub mod view_data`
389-
- [ ] Update imports in `show/views/json_view.rs`, `show/views/text_view.rs`,
382+
- [x] Create `src/presentation/cli/views/commands/list/view_data/list_details.rs`
383+
- [x] Create `src/presentation/cli/views/commands/list/view_data/mod.rs`
384+
- [x] Update `list/mod.rs` to declare `pub mod view_data`
385+
- [x] Update imports in `list/views/json_view.rs` and `list/views/text_view.rs`
386+
- [x] Create `src/presentation/cli/views/commands/show/view_data/show_details.rs`
387+
- [x] Create `src/presentation/cli/views/commands/show/view_data/mod.rs`
388+
- [x] Update `show/mod.rs` to declare `pub mod view_data`
389+
- [x] Update imports in `show/views/json_view.rs`, `show/views/text_view.rs`,
390390
and all other files under `show/views/` that import application-layer types
391-
- [ ] Verify all tests pass
392-
- [ ] Run `cargo run --bin linter all` and fix issues
391+
- [x] Verify all tests pass
392+
- [x] Run `cargo run --bin linter all` and fix issues
393393

394394
#### Testing Strategy
395395

@@ -406,18 +406,18 @@ Pure import path changes. Compilation is the primary test. No behavior changes.
406406

407407
### Approval Criteria
408408

409-
- [ ] Technical feasibility validated
410-
- [ ] Aligns with [Development Principles](../development-principles.md)
411-
- [ ] Implementation plan is clear and actionable
412-
- [ ] Priorities are correct (high-impact/low-effort first)
409+
- [x] Technical feasibility validated
410+
- [x] Aligns with [Development Principles](../development-principles.md)
411+
- [x] Implementation plan is clear and actionable
412+
- [x] Priorities are correct (high-impact/low-effort first)
413413

414414
### Completion Criteria
415415

416-
- [ ] All active proposals implemented
417-
- [ ] All tests passing
418-
- [ ] All linters passing
419-
- [ ] Documentation updated
420-
- [ ] Changes merged to main branch
416+
- [x] All active proposals implemented
417+
- [x] All tests passing
418+
- [x] All linters passing
419+
- [x] Documentation updated
420+
- [x] Changes merged to main branch
421421

422422
## 📚 Related Documentation
423423

@@ -442,5 +442,5 @@ The `show` command's `views/` subfolder already contains multiple sub-views
442442
---
443443

444444
**Created**: 2026-02-27
445-
**Last Updated**: 2026-02-27
446-
**Status**: 📋 Planning
445+
**Last Updated**: 2026-02-28
446+
**Status**: ✅ Completed

0 commit comments

Comments
 (0)