Commit 3f6b4e4
committed
c038170 feat: [#275] change Grafana default port from 3100 to 3000 (Jose Celano)
Pull request description:
## Summary
Changes the Grafana default port from 3100 to 3000, aligning with the industry standard.
## Changes
- **Template**: Updated `docker-compose.yml.tera` to expose Grafana on port 3000
- **Source code**: Updated `DEFAULT_GRAFANA_PORT` constant and all test assertions
- **Documentation**: Updated all active docs referencing port 3100
- **ADR**: Added `grafana-default-port-3000.md` documenting the decision
## Files Modified
### Template
- `templates/docker-compose/docker-compose.yml.tera` - Port mapping `3100:3000` → `3000:3000`
### Rust Source
- `src/infrastructure/remote_actions/validators/grafana.rs` - Constant and docs
- `src/application/command_handlers/show/info/grafana.rs` - URL generation and tests
- `src/presentation/views/commands/show/environment_info/grafana.rs` - Test fixtures
- `src/testing/e2e/tasks/run_run_validation.rs` - Error messages
### Documentation
- 10 documentation files updated (user guides, security docs, ADRs, e2e testing)
- New ADR created: `docs/decisions/grafana-default-port-3000.md`
## Rationale
Port 3000 is the industry standard for Grafana. The original use of port 3100 was a workaround for macOS port conflicts, but:
1. Port 3000 never actually conflicted with macOS services
2. Users expect Grafana on port 3000
3. Most documentation and tutorials use port 3000
## Testing
- ✅ All 1848 unit tests pass
- ✅ All 15 integration tests pass
- ✅ Clippy lint check passes
- ✅ Rustfmt check passes
- ✅ Markdown lint passes
Fixes #275
ACKs for top commit:
josecelano:
ACK c038170
Tree-SHA512: 556780a207bb71a0875d778b4d14e388c10fcb06f3c3513c1cafa310372c5679be2073c4842c059bc96f43c1775a9dd4839d53b9900cc145375cdbc50c195abb
16 files changed
Lines changed: 170 additions & 104 deletions
File tree
- docs
- analysis/security
- decisions
- e2e-testing/manual
- user-guide
- quick-start
- services
- src
- application/command_handlers/show/info
- infrastructure/remote_actions/validators
- presentation/views/commands/show/environment_info
- testing/e2e/tasks
- templates/docker-compose
Lines changed: 2 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | 110 | | |
112 | 111 | | |
113 | 112 | | |
114 | 113 | | |
115 | | - | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
| |||
265 | 263 | | |
266 | 264 | | |
267 | 265 | | |
268 | | - | |
269 | 266 | | |
270 | 267 | | |
271 | 268 | | |
272 | 269 | | |
273 | 270 | | |
274 | | - | |
275 | 271 | | |
276 | 272 | | |
277 | 273 | | |
278 | 274 | | |
279 | | - | |
280 | 275 | | |
281 | 276 | | |
282 | 277 | | |
283 | 278 | | |
284 | 279 | | |
285 | | - | |
286 | 280 | | |
287 | 281 | | |
288 | 282 | | |
| |||
293 | 287 | | |
294 | 288 | | |
295 | 289 | | |
296 | | - | |
297 | | - | |
| 290 | + | |
298 | 291 | | |
299 | 292 | | |
300 | 293 | | |
301 | 294 | | |
302 | | - | |
303 | 295 | | |
304 | 296 | | |
305 | 297 | | |
| |||
372 | 364 | | |
373 | 365 | | |
374 | 366 | | |
375 | | - | |
376 | 367 | | |
377 | 368 | | |
378 | 369 | | |
| |||
514 | 505 | | |
515 | 506 | | |
516 | 507 | | |
517 | | - | |
518 | 508 | | |
519 | 509 | | |
520 | 510 | | |
521 | 511 | | |
522 | 512 | | |
523 | | - | |
524 | 513 | | |
525 | 514 | | |
526 | 515 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
410 | | - | |
411 | 410 | | |
412 | 411 | | |
413 | 412 | | |
414 | 413 | | |
415 | 414 | | |
416 | | - | |
417 | 415 | | |
418 | 416 | | |
419 | 417 | | |
420 | 418 | | |
421 | 419 | | |
422 | | - | |
423 | 420 | | |
424 | 421 | | |
425 | 422 | | |
| |||
447 | 444 | | |
448 | 445 | | |
449 | 446 | | |
450 | | - | |
| 447 | + | |
451 | 448 | | |
452 | 449 | | |
453 | 450 | | |
| |||
548 | 545 | | |
549 | 546 | | |
550 | 547 | | |
551 | | - | |
552 | 548 | | |
553 | 549 | | |
554 | 550 | | |
555 | 551 | | |
556 | 552 | | |
557 | 553 | | |
558 | | - | |
559 | 554 | | |
560 | 555 | | |
561 | 556 | | |
562 | 557 | | |
563 | 558 | | |
564 | | - | |
565 | 559 | | |
566 | 560 | | |
567 | 561 | | |
568 | 562 | | |
569 | 563 | | |
570 | | - | |
571 | 564 | | |
572 | 565 | | |
573 | 566 | | |
| |||
607 | 600 | | |
608 | 601 | | |
609 | 602 | | |
610 | | - | |
| 603 | + | |
611 | 604 | | |
612 | 605 | | |
613 | 606 | | |
| |||
618 | 611 | | |
619 | 612 | | |
620 | 613 | | |
621 | | - | |
| 614 | + | |
622 | 615 | | |
623 | 616 | | |
624 | 617 | | |
| |||
651 | 644 | | |
652 | 645 | | |
653 | 646 | | |
654 | | - | |
| 647 | + | |
655 | 648 | | |
656 | 649 | | |
657 | 650 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
0 commit comments